Files

T

Amir Seify c933eefc27 fix(cursor): stop AgentService empty turns and silent tool hangs

Cursor-hosted models (cu/composer-2.5, cu/cursor-grok-*, cu/default) returned
HTTP 200 with an empty turn, or hung, whenever a client sent tools.

- Fold system prompts into the current user message. custom_system_prompt
  (RunRequest field 8) makes AgentService return an empty turn.
- Send ModelDetails (field 3); thinking variants (Composer, Grok, *-thinking)
  return an empty turn when only requested_model (field 9) is set.
- Route tool-call history and declared tool schemas through AgentService:
  encode OpenAI tools into mcp_tools (field 4), decode McpArgs and emit real
  tool_calls with finish_reason tool_calls.
- Map Composer  thinking / Grok thinking_delta (field 4) into visible content
  instead of dropping the answer with the unsigned reasoning.
- Ack request_context without echoing MCP tools (double-advertise stalls the
  HTTP/2 stream) and ack kv_server_message so the run proceeds.
- Reject IDE builtin execs instead of failing the turn, so the model can
  continue with MCP tools or a text answer.
- Add google.protobuf.Value / MCP encoders and a FIXED64 branch to
  encodeField in cursorProtobuf.js.

RTK now compresses the source-format body before translation for cursor only:
its translator rewrites role:tool into user XML, so the post-translate pass
missed those tool results. Every other provider keeps the post-translate pass
unchanged.

2026-09-21 19:49:48 +07:00

4.4 KiB

Raw Permalink Blame History

open-sse

Provider-agnostic SSE engine: one OpenAI-style request → any provider (LLM chat, image, embedding, tts, stt, search), streamed back in the client's format.

Request lifecycle (chat)

handlers/chatCore.js → services/model.js parseModel (resolve provider/model) → RTK for cursor (rtk/ compresses the source-format tool_result / role:tool in-place — its translator rewrites those shapes, so this one provider must run before translate) → translator/index.js translateRequest (client format → provider format) → post-translate savers (rtk/ compress for every other provider, rtk/headroom.js proxy compress, rtk/caveman.js / rtk/ponytail.js system inject — all fail-open) → executors/index.js getExecutor(provider) → executor.execute() (streams upstream) → translateResponse (provider chunks → client format) → SSE out.

Directory map

config/ — ALL constants/config (no hardcode elsewhere). providers.js/registry/ (provider defs), providerModels.js (alias→models matrix), runtimeConfig.js (timeouts, token limits), *Constants.js.
translator/ — format conversion. request/<from>-to-<to>.js, response/<from>-to-<to>.js, schema/ (enums: ROLE, CLAUDE_BLOCK…), concerns/ (shared logic), formats.js+formats/ (per-format). index.js is the registry/entry.
executors/ — per-provider upstream call. base.js (BaseExecutor), one file per special provider, index.js map.
providers/ — registry build + capabilities.js + pricing.js. Entry: index.js (PROVIDERS).
handlers/ — per-modality cores (chat/image/embedding/tts/stt/search) + sub-provider folders. chatCore/ has the streaming/non-streaming/sse-to-json handlers.
rtk/ — request token-killer. index.js compresses tool_result content in-place (OpenAI/Claude/Kiro shapes); filters/ per-tool compressors + autodetect.js; headroom.js external compress proxy; caveman.js system-prompt injector.
transformer/ — responsesTransformer.js (Chat Completions SSE → Codex Responses API SSE), streamToJsonConverter.js.
shared/ — cross-provider auth/identity: clineAuth.js, machineId.js, qoder/.
services/ — model.js, provider.js, accountFallback.js, combo.js, compact.js, tokenRefresh/+tokenRefresh.js, oauthCredentialManager.js, usage/, projectId.js, kiroModels.js/qoderModels.js.
utils/ — streamHandler, stream, sse, error, sessionManager, claudeCloaking, clientDetector, proxyFetch (patches global fetch), cursorProtobuf/cursorChecksum, ollamaTransform.

Conventions

Config-driven, DRY, camelCase. NEVER hardcode values, models, or block/role strings — use config/ + schema/ constants.
Translator pipeline pivots through OpenAI as the intermediate format. A translator registered on the exact source:target pair (e.g. claude:kiro) runs as a direct route, skipping the lossy double-hop.
Translators self-register via register(from, to, reqFn, resFn) as an import side-effect — new files MUST be imported in translator/index.js.

How to add

Provider: copy providers/REGISTRY_TEMPLATE.js → providers/registry/{id}.js; add models to config/providerModels.js. Generic providers need no executor (DefaultExecutor handles OpenAI-compatible APIs).
Executor (only for non-standard upstream): subclass BaseExecutor (override getBaseUrls/buildHeaders/buildUrl/execute), register in executors/index.js map. getExecutor falls back to DefaultExecutor when absent.
Translator: add request|response/<from>-to-<to>.js calling register(...), then import it in translator/index.js. Reuse schema/ + concerns/ — don't re-implement parsing.

Pitfalls

OpenAI bridge is lossy (thinking, non-base64 images, tool ids, is_error) — prefer a direct route for fragile pairs.
registry/index.js is an auto-generated static import list; regenerate it (don't hand-edit) after adding a registry/{id}.js. REGISTRY_TEMPLATE is excluded by design.
Special binary/protobuf formats (kiro EventStream, cursor protobuf, commandcode NDJSON) don't round-trip through OpenAI — handle in their executor.
rtk/ + headroom.js mutate the request body in-place and are fail-open: any error returns null and leaves the body untouched — never throw out of them. RTK skips is_error/status:"error" tool results to preserve traces.

4.4 KiB Raw Permalink Blame History