refactor(actions): safer getChannel calls

backport #10434

src/client/actions/MessageCreate.js

@@ -9,7 +9,7 @@ let deprecationEmitted = false;
 class MessageCreateAction extends Action {
   handle(data) {
     const client = this.client;
-    const channel = this.getChannel(data);
+    const channel = this.getChannel({ id: data.channel_id, guild_id: data.guild_id, author: data.author });
     if (channel) {
       if (!channel.isText()) return {};
 

src/client/actions/MessageDelete.js

@@ -7,7 +7,7 @@ const { Events } = require('../../util/Constants');
 class MessageDeleteAction extends Action {
   handle(data) {
     const client = this.client;
-    const channel = this.getChannel(data);
+    const channel = this.getChannel({ id: data.channel_id, guild_id: data.guild_id });
     let message;
     if (channel) {
       if (!channel.isText()) return {};

src/client/actions/MessageReactionAdd.js

@@ -23,7 +23,7 @@ class MessageReactionAdd extends Action {
     if (!user) return false;
 
     // Verify channel
-    const channel = this.getChannel(data);
+    const channel = this.getChannel({ id: data.channel_id, guild_id: data.guild_id, user_id: data.user_id });
     if (!channel || !channel.isText()) return false;
 
     // Verify message

src/client/actions/MessageReactionRemove.js

@@ -19,7 +19,7 @@ class MessageReactionRemove extends Action {
     if (!user) return false;
 
     // Verify channel
-    const channel = this.getChannel(data);
+    const channel = this.getChannel({ id: data.channel_id, guild_id: data.guild_id, user_id: data.user_id });
     if (!channel || !channel.isText()) return false;
 
     // Verify message

src/client/actions/MessageReactionRemoveAll.js

@@ -6,7 +6,7 @@ const { Events } = require('../../util/Constants');
 class MessageReactionRemoveAll extends Action {
   handle(data) {
     // Verify channel
-    const channel = this.getChannel(data);
+    const channel = this.getChannel({ id: data.channel_id, guild_id: data.guild_id });
     if (!channel || !channel.isText()) return false;
 
     // Verify message

src/client/actions/MessageReactionRemoveEmoji.js

@@ -5,7 +5,7 @@ const { Events } = require('../../util/Constants');
 
 class MessageReactionRemoveEmoji extends Action {
   handle(data) {
-    const channel = this.getChannel(data);
+    const channel = this.getChannel({ id: data.channel_id, guild_id: data.guild_id });
     if (!channel || !channel.isText()) return false;
 
     const message = this.getMessage(data, channel);

src/client/actions/MessageUpdate.js

@@ -4,7 +4,7 @@ const Action = require('./Action');
 
 class MessageUpdateAction extends Action {
   handle(data) {
-    const channel = this.getChannel(data);
+    const channel = this.getChannel({ id: data.channel_id, guild_id: data.guild_id });
     if (channel) {
       if (!channel.isText()) return {};
 

src/client/actions/StageInstanceCreate.js

@@ -6,7 +6,7 @@ const { Events } = require('../../util/Constants');
 class StageInstanceCreateAction extends Action {
   handle(data) {
     const client = this.client;
-    const channel = this.getChannel(data);
+    const channel = this.getChannel({ id: data.channel_id, guild_id: data.guild_id });
 
     if (channel) {
       const stageInstance = channel.guild.stageInstances._add(data);

src/client/actions/StageInstanceDelete.js

@@ -7,7 +7,7 @@ const { Events } = require('../../util/Constants');
 class StageInstanceDeleteAction extends Action {
   handle(data) {
     const client = this.client;
-    const channel = this.getChannel(data);
+    const channel = this.getChannel({ id: data.channel_id, guild_id: data.guild_id });
 
     if (channel) {
       const stageInstance = channel.guild.stageInstances._add(data);

src/client/actions/StageInstanceUpdate.js

@@ -6,7 +6,7 @@ const { Events } = require('../../util/Constants');
 class StageInstanceUpdateAction extends Action {
   handle(data) {
     const client = this.client;
-    const channel = this.getChannel(data);
+    const channel = this.getChannel({ id: data.channel_id, guild_id: data.guild_id });
 
     if (channel) {
       const oldStageInstance = channel.guild.stageInstances.cache.get(data.id)?._clone() ?? null;

src/client/actions/TypingStart.js

@@ -6,7 +6,7 @@ const { Events } = require('../../util/Constants');
 
 class TypingStart extends Action {
   handle(data) {
-    const channel = this.getChannel(data);
+    const channel = this.getChannel({ id: data.channel_id, guild_id: data.guild_id });
     if (!channel) return;
 
     if (!channel.isText()) {