refactor: remove extra traversing

#10580 djs
This commit is contained in:
Elysia
2025-01-21 02:11:19 +07:00
parent 62d2630643
commit 3a0d5745ea
3 changed files with 4 additions and 7 deletions

View File

@@ -298,7 +298,7 @@ class GuildChannelManager extends CachedManager {
if (data.lockPermissions) { if (data.lockPermissions) {
if (parentId) { if (parentId) {
const newParent = this.guild.channels.cache.get(parentId); const newParent = this.cache.get(parentId);
if (newParent?.type === 'GUILD_CATEGORY') { if (newParent?.type === 'GUILD_CATEGORY') {
permission_overwrites = newParent.permissionOverwrites.cache.map(o => permission_overwrites = newParent.permissionOverwrites.cache.map(o =>
PermissionOverwrites.resolve(o, this.guild), PermissionOverwrites.resolve(o, this.guild),

View File

@@ -470,7 +470,7 @@ class GuildMemberManager extends CachedManager {
* @returns {Promise<GuildMember|User|Snowflake>} * @returns {Promise<GuildMember|User|Snowflake>}
*/ */
async addRole(user, role, reason) { async addRole(user, role, reason) {
const userId = this.guild.members.resolveId(user); const userId = this.resolveId(user);
const roleId = this.guild.roles.resolveId(role); const roleId = this.guild.roles.resolveId(role);
await this.client.api.guilds(this.guild.id).members(userId).roles(roleId).put({ reason }); await this.client.api.guilds(this.guild.id).members(userId).roles(roleId).put({ reason });
@@ -486,7 +486,7 @@ class GuildMemberManager extends CachedManager {
* @returns {Promise<GuildMember|User|Snowflake>} * @returns {Promise<GuildMember|User|Snowflake>}
*/ */
async removeRole(user, role, reason) { async removeRole(user, role, reason) {
const userId = this.guild.members.resolveId(user); const userId = this.resolveId(user);
const roleId = this.guild.roles.resolveId(role); const roleId = this.guild.roles.resolveId(role);
await this.client.api.guilds(this.guild.id).members(userId).roles(roleId).delete({ reason }); await this.client.api.guilds(this.guild.id).members(userId).roles(roleId).delete({ reason });

View File

@@ -174,10 +174,7 @@ class GuildScheduledEventManager extends CachedManager {
return data.reduce( return data.reduce(
(coll, rawGuildScheduledEventData) => (coll, rawGuildScheduledEventData) =>
coll.set( coll.set(rawGuildScheduledEventData.id, this._add(rawGuildScheduledEventData, options.cache)),
rawGuildScheduledEventData.id,
this.guild.scheduledEvents._add(rawGuildScheduledEventData, options.cache),
),
new Collection(), new Collection(),
); );
} }