 asepharyanaandClaude Opus 4.8
|
9a6ab62562
|
refactor: DRY cleanup — extract shared helpers, remove duplication across tools, LSP, overlays, and runtime
Eliminate ~500 lines of duplicate code across 31 files by extracting
shared functions, helpers, and consolidating repeated patterns.
Highlights:
- Toast helpers (toast_info/success/warning/error) on AppStateRest
- push_event() helper for turn-event queue (19 callers consolidated)
- log_write_edit_tool() shared fn (turn.rs + engine.rs ~50 lines saved)
- resolve_api_key() shared fn (spawn.rs + provider.rs)
- LSP call_positional() helper on LspClient
- lsp_cursor_params() shared schema for 4 tool files
-overlay_block() helper for consistent overlay title/border styling
- cycle_selected_index(), path_not_found/a_directory() helpers
- mark_dirty(), save_settings() on AppStateRest
- Remove redundant Err(e) => Err(e) arms in LSP tools
- Consolidate generate_workspace_tree (turn.rs → workspace.rs)
- Simplify background-review wrapper args in auto/mod.rs
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
2026-07-18 03:18:27 +07:00 |
|
|
asepharyana
|
9a67137954
|
refactor: massive codebase restructuring — naming, splitting, DRY
Crate renames:
- zesdex-entities::seaorm → domain (misleading name, no SeaORM used)
- zesdex-dto → merged into zesdex-entities (100% re-exports)
- zesdex-libs → zesdex-infra (vague name)
Module renames:
- app/harness → guard (misleading: safety gatekeeper, not test harness)
- runtime/commands → action_dispatch (name clashed with controller/command)
- resources → prompts (embedded prompt text, not general resources)
- tool/seqthink → sequential_think (unreadable abbreviation)
- msglog/query → insert (module only inserts, never queries)
Dead code removal:
- app/mode/help.rs (orphaned — not declared in mod.rs)
- app/mode/loading.rs (orphaned — not declared in mod.rs)
File splitting (71 new files, avg ~115 lines/file):
- app/runtime/actions/: 1→8 files (was 2030 lines)
- view/overlays/: 1→16 files (was 1167 lines)
- tool/lsp/: 1→8 per-tool files (was 909 lines)
- main.rs: 1→5 files (session, daemon, attach, event_loop)
- workflow/engine + hive_mind: 2→10 files
- subagent/engine + auto: 2→9 files
- lsp/provisioner: 1→5 files
- review/: 1→6 files
- guard/: 1→2 files (extracted patterns)
- state/misc: 1→3 files (input, scroll)
- mcp/: 1→3 files (transport, adapter)
- stream/json_repair extracted from turn.rs
DRY:
- Pattern constants (STUB_PATTERNS etc) in guard/patterns shared with subagent
- 3 near-identical background spawners → 1 generic + thin wrappers
- Shared spawn_subagent_with_drain() extracted
- Shared create_session() in main
- write_osc52 deduplicated
Bug fixes:
- archive_message(): sess.db → db (wrong variable name)
- execute_one_tool(): wrong parameter name
- check_credential_read() function was missing (restored from test expectations)
|
2026-07-17 09:08:41 +07:00 |
|