feat(agent): wire auto-review (review_enabled no-op -> nyata)
review_enabled (default TRUE) selama ini no-op: tampil di TUI settings
overlay ("Review: true"), bisa di-toggle via command, TAPI spawn_background_review
tidak pernah dipanggil & Origin::Reviewer tidak pernah dikonstruksi. User
melihat "Review: true" padahal auto-review setelah edit tak pernah jalan.
Sekarang feature yang sudah dibangun penuh (subagent/auto/engine.rs: git diff
-> LLM review -> auto-fix HIGH/MEDIUM) di-wire:
- daemon/handler.rs: trigger setelah run_turn bila review_enabled; capture
flag+creds SEBELUM api_key/provider_cfg di-move ke LlmClient.
- tui/turn.rs: sama, gated by state.settings.flags.review_enabled.
- ws/lib.rs: channel minimal tanpa settings -> review nyala tiap prompt
(konsisten dgn default ON).
Aman: review fire-and-forget (tokio::spawn), get_git_diff skip bila no-change,
no-op bila bukan git repo (auto/engine). Creds dipakai = creds ter-resolve yg
sama dgn komposisi turn.
Verifikasi: check/clippy/fmt/test workspace hijau (0 error/warning/fail).
This commit is contained in:
@@ -130,6 +130,17 @@ async fn handle_socket(mut socket: WebSocket, state: Arc<WsState>) {
|
||||
api_base: None,
|
||||
};
|
||||
|
||||
// Capture for the optional background auto-review
|
||||
// before `api_key`/`model` move into the client.
|
||||
// This minimal WS channel has no settings toggle, so
|
||||
// review fires whenever a prompt runs (consistent
|
||||
// with the default review_enabled=true).
|
||||
let review_key = api_key.clone();
|
||||
let review_model = model.clone();
|
||||
let review_base = None;
|
||||
let review_ws = workspace_roots.clone();
|
||||
let review_events = turn_events.clone();
|
||||
|
||||
let client = std::sync::Arc::new(
|
||||
zesdex_infrastructure::llm::provider::LlmClient::new(
|
||||
api_key, model, None,
|
||||
@@ -159,6 +170,13 @@ async fn handle_socket(mut socket: WebSocket, state: Arc<WsState>) {
|
||||
use zesdex_application::agent::AgentTurnService;
|
||||
tokio::spawn(async move {
|
||||
let _ = turn_service.run_turn(params).await;
|
||||
zesdex_infrastructure::subagent::auto::engine::spawn_background_review(
|
||||
review_ws,
|
||||
review_events,
|
||||
review_key,
|
||||
review_model,
|
||||
review_base,
|
||||
);
|
||||
});
|
||||
|
||||
let tx_clone = tx.clone();
|
||||
|
||||
Reference in New Issue
Block a user