fix: improve expert review form accessibility
- Add proper id/htmlFor associations for verified/corrected radio inputs
- Clear correctedDiseaseSlug when switching verdict to verified to prevent stale state
- Add required={verdict === 'corrected'} to disease select
- Add loading state distinguishing between loading reviews/diseases and empty queue
- Add type="button" to diagnosis list selection buttons
- Improve selected diagnosis image alt text to include disease name
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.7
parent
1b24e6f6a0
commit
be569ff675
@@ -68,12 +68,15 @@ export function ExpertReviewsPage() {
|
|||||||
</div>
|
</div>
|
||||||
|
|
||||||
<div className="space-y-2">
|
<div className="space-y-2">
|
||||||
{reviews.length === 0 ? (
|
{reviewsQuery.isPending || diseasesQuery.isPending ? (
|
||||||
|
<p className="text-sm text-muted-foreground">Loading reviews and diseases...</p>
|
||||||
|
) : reviews.length === 0 ? (
|
||||||
<p className="text-sm text-muted-foreground">No diagnoses pending review</p>
|
<p className="text-sm text-muted-foreground">No diagnoses pending review</p>
|
||||||
) : (
|
) : (
|
||||||
reviews.map((review) => (
|
reviews.map((review) => (
|
||||||
<button
|
<button
|
||||||
key={review.id}
|
key={review.id}
|
||||||
|
type="button"
|
||||||
onClick={() => setSearchParams({ diagnosis: review.id })}
|
onClick={() => setSearchParams({ diagnosis: review.id })}
|
||||||
className={`w-full text-left transition ${
|
className={`w-full text-left transition ${
|
||||||
selected?.id === review.id
|
selected?.id === review.id
|
||||||
@@ -108,7 +111,13 @@ export function ExpertReviewsPage() {
|
|||||||
|
|
||||||
{/* Right: Detail and form */}
|
{/* Right: Detail and form */}
|
||||||
<div className="lg:col-span-2 space-y-6">
|
<div className="lg:col-span-2 space-y-6">
|
||||||
{selected ? (
|
{reviewsQuery.isPending || diseasesQuery.isPending ? (
|
||||||
|
<Card>
|
||||||
|
<CardContent className="p-6 text-center text-muted-foreground">
|
||||||
|
Loading reviews and diseases...
|
||||||
|
</CardContent>
|
||||||
|
</Card>
|
||||||
|
) : selected ? (
|
||||||
<>
|
<>
|
||||||
{/* Detail card */}
|
{/* Detail card */}
|
||||||
<Card>
|
<Card>
|
||||||
@@ -121,7 +130,7 @@ export function ExpertReviewsPage() {
|
|||||||
<CardContent className="space-y-4">
|
<CardContent className="space-y-4">
|
||||||
<img
|
<img
|
||||||
src={selected.imageUrl}
|
src={selected.imageUrl}
|
||||||
alt="Daun jagung"
|
alt={`Gambar daun jagung untuk ${selected.disease?.commonName ?? 'diagnosis'}`}
|
||||||
className="h-64 w-full rounded-lg object-cover"
|
className="h-64 w-full rounded-lg object-cover"
|
||||||
/>
|
/>
|
||||||
|
|
||||||
@@ -166,19 +175,24 @@ export function ExpertReviewsPage() {
|
|||||||
<div className="space-y-2">
|
<div className="space-y-2">
|
||||||
<label className="text-sm font-medium">Verdict</label>
|
<label className="text-sm font-medium">Verdict</label>
|
||||||
<div className="flex gap-3">
|
<div className="flex gap-3">
|
||||||
<label className="flex items-center gap-2">
|
<label htmlFor="verdict-verified" className="flex items-center gap-2">
|
||||||
<input
|
<input
|
||||||
|
id="verdict-verified"
|
||||||
type="radio"
|
type="radio"
|
||||||
name="verdict"
|
name="verdict"
|
||||||
value="verified"
|
value="verified"
|
||||||
checked={verdict === 'verified'}
|
checked={verdict === 'verified'}
|
||||||
onChange={(e) => setVerdict(e.target.value as 'verified' | 'corrected')}
|
onChange={(e) => {
|
||||||
|
setVerdict(e.target.value as 'verified' | 'corrected');
|
||||||
|
setCorrectedDiseaseSlug('');
|
||||||
|
}}
|
||||||
className="h-4 w-4"
|
className="h-4 w-4"
|
||||||
/>
|
/>
|
||||||
<span className="text-sm">Verified</span>
|
<span className="text-sm">Verified</span>
|
||||||
</label>
|
</label>
|
||||||
<label className="flex items-center gap-2">
|
<label htmlFor="verdict-corrected" className="flex items-center gap-2">
|
||||||
<input
|
<input
|
||||||
|
id="verdict-corrected"
|
||||||
type="radio"
|
type="radio"
|
||||||
name="verdict"
|
name="verdict"
|
||||||
value="corrected"
|
value="corrected"
|
||||||
@@ -201,6 +215,7 @@ export function ExpertReviewsPage() {
|
|||||||
id="disease"
|
id="disease"
|
||||||
value={correctedDiseaseSlug}
|
value={correctedDiseaseSlug}
|
||||||
onChange={(e) => setCorrectedDiseaseSlug(e.target.value as DiseaseSlug | '')}
|
onChange={(e) => setCorrectedDiseaseSlug(e.target.value as DiseaseSlug | '')}
|
||||||
|
required={verdict === 'corrected'}
|
||||||
className="w-full rounded-md border border-border bg-background px-3 py-2 text-sm"
|
className="w-full rounded-md border border-border bg-background px-3 py-2 text-sm"
|
||||||
>
|
>
|
||||||
<option value="">Select a disease...</option>
|
<option value="">Select a disease...</option>
|
||||||
|
|||||||
Reference in New Issue
Block a user