Compare commits

...
8 Commits
Author SHA1 Message Date
asepharyana 0157029da8 fix: pin autofix agent to claude-sonnet-5 via custom:9router provider 2026-09-23 22:00:02 +07:00
asepharyana 66b567a6bc feat(worker): per-fork session header + 3600s sync timeout + merge salvage
- _hermes_api_post sends X-Hermes-Session-Id so each fork sync uses a
  fresh gateway transcript (was: derived session reused 200k-token history
  across upstream tips, making later runs pay growing context)
- SYNC_CLAUDE_TIMEOUT 2700→3600: a fresh session needs ~25min/120 calls
  to resolve 17 files + verify + commit; 2700s cut the HTTP call while the
  agent was still committing
- salvage-on-timeout: when the agent call ends early (timeout/transport)
  but the merge is already committed (MERGE_HEAD gone), finish+push it
  instead of aborting — verified live: 17 conflicts resolved by agent,
  push ok, fork 27 ahead / 0 behind
- _sync_finish_merge blocks committing files that still carry conflict
  markers (guard against git add of unresolved files)
- tests: 68/68 (session header, salvage completed merge, abort unfinished,
  marker guard; fake-leak hardening in _install_git_fake)
2026-09-21 21:02:33 +07:00
asepharyana 99d47c8ff8 feat(worker): drive Hermes gateway API server instead of claude -p
Claude Code could not complete AI fixes / conflict resolution against this
host's provider setup: it hung 900s spawning an MCP server, then failed with
'body is JSON but not a Message' (Anthropic-Messages transport mismatch), then
exited 1 with empty stderr. The Hermes gateway already runs continuously with
the working 9router provider config and a full toolset, so drive it directly:

- POST http://127.0.0.1:8642/v1/chat/completions (OpenAI-compatible API server)
- bearer auth from API_SERVER_KEY (env or ~/.hermes/.env), overridable via
  API_SERVER_URL
- model_options.max_turns caps a runaway run; 900s timeout for sync, 600s for
  PR fixes
- every failure maps to an [INFRA] string so the existing skip-once logic works
- the agent commits locally; the WORKER pushes (agents must never push)

run_ai_fix no longer shells out to claude; it calls the API server, then pushes
the agent's commit itself and reports push failures explicitly. Sync call sites
keep their contract via _run_claude_sync -> _run_hermes_sync alias, with labels
renamed hermes_sync_conflicts / hermes_sync_quality.

Tests: 59/59 (8 new assertions exercise a real local HTTP round-trip: path,
bearer auth, OpenAI message shape, max_turns cap, HTTP-error/missing-key/
unreachable -> [INFRA]).
2026-09-21 18:24:47 +07:00
asepharyana 0653f6c508 fix(worker): pure --dry runs + Claude Code MCP-server hang
- --dry now touches nothing: no state file writes (run_upstream_sync uses a
  throwaway state dict; sync_fork_repo refuses to mutate in dry), no Discord,
  no push, no PR (protected-branch dry prints would-open instead). The earlier
  dry run polluted /tmp/pr-queue-sync-state.json and posted a false 'skip'
  notification — both are gone.
- Claude Code conflict/quality runs now use --strict-mcp-config (with
  --mcp-config ''): --mcp-config '' alone still lets claude -p spawn MCP
  servers from settings.json/managed/plugins (observed ouroboros mcp serve
  hanging 15+ min with zero output until the 900s timeout). These calls only
  read/edit a throwaway clone and run git — no MCP server is ever needed.
- tests: 51/51 (added dry-purity cases: clean-merge, conflict-failure).
2026-09-21 17:31:16 +07:00
asepharyana c48adea6c3 feat(worker): upstream fork auto-sync — pull+merge fork repos hourly
Merge new upstream (parent) commits into every fork in the App installation,
gated by a per-repo interval (default 1h), inside the existing 5-minute tick
(STEP 0, max 2 forks/tick, oldest-first).

- Conflicted merges are resolved by Claude Code (merge-reconciler rules:
  never wholesale --ours/--theirs, verify with the repo's own
  typecheck+tests, commit --no-edit; Claude never pushes — harness does).
- Clean merges get a single Claude Code quality pass commit.
- Push path: owner PAT (gh CLI) first — the App lacks workflows:write and a
  workflows-touching merge is rejected for the App token; App token fallback.
- Protected default branch: detected from the push result (GH006 /
  required-status-check) → upstream-sync-<ts> branch + PR through the normal
  pipeline; duplicate open sync PRs are skipped.
- CI safety: after a direct push, ticks verify the fork CI at our merge sha;
  red CI at OUR merge (still the tip) → sha-guarded force-revert to
  pre-merge sha + Discord notify; never reverts foreign commits.
- Discord: synced / PR opened / reverted / skipped-once on pr-agent-ops.
- merge_pr gains the same PAT fallback (a PR merge touching workflows is a
  workflow-file push).
- CLI: --sync-status, --sync-only <repo> [--dry].
- Tests: scripts/test_pr_queue_sync.py (46 assertions, monkeypatched, no
  network); py_compile clean.
- Plan: .hermes/plans/2026-09-21-upstream-auto-sync.md
2026-09-21 17:04:39 +07:00
asepharyana 1dc4d098fa feat(worker): skip-on-error no loop + conflict auto-fix + deduped notif
1. Skip ONCE on infra errors (Claude Code CLI missing/timeout/unreachable):
   - run_ai_fix returns '[INFRA] ...' reasons; worker marks the PR permanently
     skipped at that head SHA in fix-state (no more retry every 5 min)
   - skip is recorded per {repo,pr,sha}; cleared when head SHA changes
2. Merge conflict auto-fix via Claude Code:
   - mergeable=False or merge HTTP 409 now trigger run_ai_fix (prompt already
     merges base + resolves conflicts) once per head SHA
   - success → next tick re-checks mergeable and merges; failure → skip once
3. Discord skip notification dedupe:
   - notify_skip_once(): posts '⏭️ Skipped: <reason>' exactly once per
     PR+head_sha (state.notified flag); no repeated spam every cron tick
   - skip reason + which PR is visible in the notification
4. State migration: legacy {repo:{pr:'sha'}} → dict form handled in _pr_entry
Verified: py_compile clean, state-helper unit tests pass (skip/fixed/notify
dedupe/legacy migration). Cron wrapper execs repo copy — no manual sync.
2026-09-21 15:58:52 +07:00
asepharyana 296f825347 fix(discord): strip HTML table markup from review notifications
Discord embeds render markdown, not HTML — the PR Reviewer Guide table
(<table><tr><td>…) was appearing as literal HTML in the webhook message.
Added htmlToDiscordPlain(): collapses the table into readable lines
(score/effort/security/key-issues), keeps emoji + **bold** markdown, and
decodes entities. Also fixed review score suffix '/10' → '/100' (the LLM
score scale is 0-100, matching the table's 'Score: 72').
2026-09-21 15:38:21 +07:00
asepharyana 391743780d fix(discord): review score scale is 0-100 not /10
The LLM review score comes from the PR Reviewer Guide table which uses a
0-100 scale (72, 78, 100...). The Discord notification appended '/10',
making it read 'score 72/10'. Fixed to '/100' to match the actual scale.
2026-09-21 15:35:30 +07:00
7 changed files with 2135 additions and 79 deletions

No files matched your search

@@ -0,0 +1,67 @@
# Queue Worker Resiliency — Skip on Error + Conflict Auto-fix + Deduped Notify
## Goal
Make pr-queue-worker.py resilient: no infinite looping on infra errors,
auto-resolve merge conflicts via Claude Code, and notify Discord about skips
exactly once (no repeated spam).
## Scope
- `scripts/pr-queue-worker.py` only (cron worker, canonical in repo)
- State persisted in `/tmp/pr-queue-fix-state.json` (already exists)
## Changes
### A. Skip-on-error (no loop) — fix-state gains skip reasons
Current `FIX_STATE_FILE` shape: `{repo: {pr: head_sha}}` (fixed map).
Extend value to either a string SHA (fixed) or a dict for skip:
`{repo: {pr: {"fixed_sha": "<sha>", "skip_reason": "<reason>", "skip_sha": "<sha>"}}}`
- `run_ai_fix` failure kinds:
- CLI not found / not executable → **infra error** → mark skipped, notify once
- timeout → mark skipped (Claude hung), notify once
- "Claude ran but no push" → NOT infra error (Claude worked, nothing to fix)
→ allow retry next tick (cheap) OR mark fixed? — decide: keep retry (this
is often a transient "no changes needed" state, but re-running every tick
is exactly the loop user complains about) → **mark skipped too** (reason
"no changes produced"), notify once, so it stops looping. User can re-open.
- clone failed → transient (network) → retry next tick (NOT skip) — but cap:
track clone-fail attempts, after 3 → skip w/ notify.
- `already_fixed` semantics: returns True also for skip state (same SHA) so we
don't re-run OR re-notify.
- New helper `mark_skip(state, repo, pr, sha, reason)` + `get_skip(state,...)`.
### B. Merge conflict → Claude Code resolve
- When `mergeable is False` (GitHub says conflict) OR merge returns 409:
- If not already attempted at this SHA (fix-state): run `run_ai_fix` (its
prompt already includes "merge base + resolve conflicts intelligently").
- If fix returns True → continue to re-check mergeability next iteration
(head SHA changed; loop naturally proceeds).
- If fix returns False (error/no push) → mark skip + notify once.
- Prevent infinite conflict-fix loop: one AI attempt per head SHA (fix-state
`fixed_sha` covers it). If Claude pushes but conflict persists → next tick
`mergeable is False` again but fix-state SHA = old → we'd re-run. Fix:
mark conflict-resolve-attempted in state with the head SHA and the *result*
("conflict-fix-pushed" / "conflict-fix-failed"); skip re-run on same SHA.
### C. Deduped Discord notification for skips
- State file gains `notified: {repo: {pr: {"reason": sha}}}` (or embed in skip
entry: when we notify, record sha; skip notify if same sha+reason already
notified).
- Notification: one embed per skip reason, listing PRs:
`⚠️ Skipped: #19 (dependabot) — Clode Code CLI not found` — only on first
occurrence per PR+reason, not every 5-min tick.
- The full run report (flush_log) still goes out each tick — that's the
periodic status, fine. The dedupe applies to *skip-specific* notifications.
## Files touched
- `scripts/pr-queue-worker.py`
## Verification
- Unit-ish: run worker with a fake PR? Hard (needs GitHub). Instead:
- py_compile
- dry-run logic test: monkeypatch run_ai_fix to return False with
"Claude Code CLI not found" → assert mark_skip called once, second run
skips re-attempt, notify once (check state file).
- conflict path: monkeypatch mergeable False + run_ai_fix True → assert
conflict-fix-attempt recorded once.
- Live: after deploy, open a tiny conflicting PR (or use an existing one) and
watch one skip notification, then verify no repeat next tick.
@@ -0,0 +1,101 @@
# Upstream Auto-Sync — Auto Pull + Merge for Fork Repos
Status: implemented in `scripts/pr-queue-worker.py` (2026-09-21).
User decisions: interval **1 hour**, sync PRs **do** get the Claude Code auto-fix.
## Goal
For every repo the GitHub App is installed on whose GitHub metadata says
`fork: true`, pull the commits the upstream (parent) repo has that the fork lacks
and MERGE them into the fork's default branch — with conflict resolution, CI
verification and deduped notifications. No new cron/service: the existing
`pr-queue-worker.py` tick (every 5 min) runs it, gated by a per-repo interval.
## Fork state at build time (live)
| Fork | Parent | To merge | Fork divergence |
|---|---|---|---|
| `asepharyana/shiro-neko` | `zakirkun/shiro-neko` | 4 | 26 |
| `asepharyana/hermes-agent-mission-control` | `sharbelxyz/hermes-agent-mission-control` | 0 | 8 |
Both default branches are unprotected; the real shiro-neko merge conflicts in 14
files (`src/tools.ts`, `src/ui/App.tsx`, `src/tests…`).
## Design decisions (with reasons)
1. **Merge, never rebase** — preserves fork history/divergence (skill
`fork-upstream-sync`).
2. **Inside `pr-queue-worker.py`** — the worker already owns the atomic cron
lock, installation tokens and Discord plumbing; the sync is STEP 0 of the same
tick, bounded to `max_per_tick = 2` forks, oldest-attempt-first so the budget
rotates fairly.
3. **1h interval per repo** — the compare API is checked every tick (cheap), a
merge attempt only when the interval elapsed AND the upstream tip changed
(`last_attempt_sha`), so a failed/skipped sync is not retried every 5 minutes.
4. **Conflicted merges go to Claude Code** — `resolve_conflicts: true`. The
prompt encodes the `fork-upstream-sync` rules (merge hunks by hand, never
wholesale `--ours/--theirs`, strip UTF-8 BOM, run the repo's typecheck+tests
before committing) plus the `merge-reconciler` impartiality contract (classify
every hunk: disjoint-intent / same-question-different-answer / superseded;
change nothing outside conflict markers; report every decision).
Claude never pushes — the harness pushes.
5. **Clean merges get a quality pass** — `ai_fix_after_merge: true` runs one
Claude Code pass over the merged files and commits
`fix: auto-fix code quality [skip ci]`. On the PR path the normal worker AI
fix applies (user decision), so sync PRs are treated like any other PR.
6. **Push path: owner PAT first, App token second** — the App has
`contents:write` but NOT `workflows:write`, and the shiro-neko merge touches
`.github/workflows/*`, so an App-token push is rejected. Clones use the App
token; pushes use the gh CLI PAT (`_fetch_gh_token()`).
7. **Protected branch → PR path** — App tokens get 403 (not 404) on the
branch-protection endpoint, so protection is detected from the PUSH result
(GH006 / "protected branch" / required-status-check markers) and falls back to
pushing a `upstream-sync-<ts>` branch + opening a PR that the normal pipeline
finishes. Duplicate PRs are avoided by scanning open PRs for that head prefix.
8. **CI verify with sha-guarded auto-revert** — `verify_ci: true`. After a direct
push, later ticks check the fork's CI at our merge sha; if it is still the tip
and CI failed, the branch is force-pushed back to `pre_merge_sha` and Discord
is notified. Never reverts when a human pushed on top; never applies to the
protected/PR path; watch stops after `verify_ci_max_age_h = 6h`.
9. **Discord**: sync events go to the same `pr-agent-ops` webhook as the run
reports (synced / PR opened / reverted / skipped-once).
10. **`merge_pr` PAT fallback** — a PR merge that changes workflow files is also
a workflow-file push, so a 403 on the App merge retries with the PAT.
## Scope
- `scripts/pr-queue-worker.py` — new `# Upstream Fork Auto-Sync` section (config,
discovery, compare, merge, conflict-resolve, push, PR path, verify/revert,
orchestrator) + STEP 0 in `main()` + CLI flags.
- `scripts/test_pr_queue_sync.py` — new: 46 assertions over the orchestration.
- State: `/tmp/pr-queue-sync-state.json`; workdirs `/tmp/pr-queue-sync-work/`.
- No changes to `server/` (Bun), systemd units or the cron list.
## State shape
```json
{"owner/fork": {
"last_sync_ts": 0, "last_attempt_sha": "", "last_merged_upstream_sha": "",
"skip_reason": "", "notified": false,
"pending_verify": {"sha": "", "pre_merge_sha": "", "branch": "main", "pushed_at": 0}
}}
```
## CLI (manual/dev)
```bash
python3 scripts/pr-queue-worker.py --sync-status
python3 scripts/pr-queue-worker.py --sync-only asepharyana/shiro-neko --dry
python3 scripts/pr-queue-worker.py --sync-only asepharyana/shiro-neko
```
`--dry` runs the whole flow (clone, merge, Claude conflict resolution) and stops
before pushing, leaving the prepared workdir in `/tmp/pr-queue-sync-work/<repo>`.
## Verification
- `python3 -m py_compile` clean.
- `python3 scripts/test_pr_queue_sync.py` → 46/46 (gating, clean merge, conflict
resolution, failed resolution skip+dedupe, protected→PR, CI green/red/foreign-
commit/running, fork discovery, push-error classification, config override).
- Live dry run against the real fork: clone + upstream fetch + conflicted merge +
Claude Code resolution, verified with the repo's own `bun run typecheck`/`bun test`.
- Live production: the 5-minute cron picks it up on the next tick after the push
(the cron wrapper ff-only pulls this repo and execs the repo copy).
- Regression guard for the bug the dry run caught: compare head ref must be
`{owner}:{branch}` — a full `owner/repo:branch` head 404s.
## Out of scope
- Syncing non-default branches; pushing fork→upstream; scheduled rebase option.
+42 -5
View File
@@ -8,13 +8,50 @@ repos where the PR-Agent GitHub App is installed and drives the full lifecycle:
2. **Toolchain pin guard** → closes dependabot PRs that bump pinned toolchain 2. **Toolchain pin guard** → closes dependabot PRs that bump pinned toolchain
majors (see `TOOLCHAIN_PINS` map — typescript/eslint/@tsparticles/…) instead majors (see `TOOLCHAIN_PINS` map — typescript/eslint/@tsparticles/…) instead
of waiting on them forever of waiting on them forever
3. **AI auto-fix** → runs Claude Code (`-p`) on the PR head for up to 3. **AI auto-fix** → runs the Hermes agent via the local gateway API server
`AI_FIX_MAX_TURNS` turns, then pushes the fix (`POST /v1/chat/completions` on `127.0.0.1:8642`, `API_SERVER_KEY`) on the PR
4. **Safety analysis** → parses the review body for security/major-issue head for up to `AI_FIX_MAX_TURNS` turns, commits locally, then the worker
pushes the fix
5. **Safety analysis** → parses the review body for security/major-issue
blockers; score must be ≥ 6/10 blockers; score must be ≥ 6/10
5. **CI gate** → waits for the required check to pass (closes stale dependabot 6. **CI gate** → waits for the required check to pass (closes stale dependabot
PRs stuck failing CI for > `STALE_CI_CLOSE_DAYS`) PRs stuck failing CI for > `STALE_CI_CLOSE_DAYS`)
6. **Approve + merge** 7. **Approve + merge**
## Upstream Fork Auto-Sync
Since 2026-09-21 the same 5-minute tick also syncs every repo in the App
installation whose GitHub metadata says `fork: true`: new upstream (parent)
commits are **merged** (never rebased) into the fork's default branch, gated by
a per-repo interval (default **1 hour**; `UPSTREAM_SYNC` config block).
- **Conflicted merge** → the Hermes agent (via the gateway API server) resolves
it (merge-reconciler rules: merge hunks by hand, never wholesale
`--ours/--theirs`, run the repo's own typecheck/tests before committing). The
agent never pushes — the harness does.
- **Clean merge** → one Hermes quality pass over the merged files, committed as
`fix: auto-fix code quality [skip ci]`.
- **Protected default branch** → detect from the push result (GH006 /
required-status-check) and fall back to opening an `upstream-sync-*` PR that
the normal pipeline (review → AI fix → CI → approve → merge) finishes.
- **CI safety** → after a direct push the worker verifies the fork's CI at our
merge commit; a red CI at OUR merge sha (still the tip, no human commits on
top) force-reverts to the pre-merge sha. Watch stops after 6 h.
- **Push credentials** → owner PAT (gh CLI) first because the App lacks
`workflows:write`; App token is the fallback. Clones use the App token.
- **State** → `/tmp/pr-queue-sync-state.json` (skip/interval/pending-verify),
workdirs `/tmp/pr-queue-sync-work/`.
- **Notifications** → same `pr-agent-ops` Discord webhook: synced, PR opened,
reverted, skipped-once.
Manual/dev:
```bash
python3 scripts/pr-queue-worker.py --sync-status
python3 scripts/pr-queue-worker.py --sync-only asepharyana/shiro-neko --dry # stops before push
python3 scripts/pr-queue-worker.py --sync-only asepharyana/shiro-neko
```
Tests: `python3 scripts/test_pr_queue_sync.py` (51 assertions; no network —
gh_api/git/Hermes API/push are monkeypatched).
## Deployment ## Deployment
+1097 -72
View File
File diff suppressed because it is too large. Load diff
+98
View File
@@ -0,0 +1,98 @@
#!/usr/bin/env python3
"""Standalone smoke test for the Hermes gateway API server adapter.
Starts APIServerAdapter on a private port (default 8643) using the LIVE hermes
install, then drives a real agent turn through POST /v1/chat/completions —
proving the whole path the pr-queue-worker depends on:
bearer auth -> route -> AIAgent -> toolset (terminal/file) -> response
No gateway restart needed and nothing in the running gateway is touched.
"""
import argparse
import asyncio
import json
import os
import sys
import time
INSTALL = os.environ.get("HERMES_INSTALL", "/home/code/.hermes/hermes-agent")
sys.path.insert(0, INSTALL)
def main():
ap = argparse.ArgumentParser()
ap.add_argument("--port", type=int, default=8643)
ap.add_argument("--key", default="standalone-smoke-key-0123456789abcdef")
ap.add_argument("--prompt", default=None)
ap.add_argument("--timeout", type=float, default=300.0)
ap.add_argument("--keep-alive", action="store_true", help="serve until Ctrl-C")
args = ap.parse_args()
os.environ["API_SERVER_KEY"] = args.key
os.environ["API_SERVER_HOST"] = "127.0.0.1"
os.environ["API_SERVER_PORT"] = str(args.port)
from gateway.config import PlatformConfig, Platform
from gateway.platforms.api_server import APIServerAdapter
cfg = PlatformConfig(enabled=True, extra={"host": "127.0.0.1", "port": args.port, "key": args.key})
adapter = APIServerAdapter(cfg)
print(f"[smoke] starting API server adapter on 127.0.0.1:{args.port}", flush=True)
async def run():
ok = await adapter.connect()
print(f"[smoke] connect() -> {ok}", flush=True)
if not ok:
err = getattr(adapter, "_fatal_error", None) or getattr(adapter, "fatal_error", None)
print(f"[smoke] fatal: {err}", flush=True)
return 1
if args.keep_alive:
print("[smoke] serving — Ctrl-C to stop", flush=True)
while True:
await asyncio.sleep(3600)
await asyncio.sleep(0.5)
import httpx
prompt = args.prompt or (
"Use your terminal tool to run exactly: echo HERMES_API_OK && pwd\n"
"Then reply with the raw output only."
)
body = {
"model": "hermes-agent",
"messages": [{"role": "user", "content": prompt}],
"stream": False,
}
url = f"http://127.0.0.1:{args.port}/v1/chat/completions"
t0 = time.time()
try:
async with httpx.AsyncClient(timeout=args.timeout) as client:
r = await client.post(url, headers={"Authorization": f"Bearer {args.key}"}, json=body)
dt = time.time() - t0
print(f"[smoke] HTTP {r.status_code} in {dt:.1f}s", flush=True)
print("[smoke] body:", r.text[:1500], flush=True)
if r.status_code != 200:
return 1
data = r.json()
text = (data.get("choices") or [{}])[0].get("message", {}).get("content", "")
print(f"[smoke] agent text: {text[:400]!r}", flush=True)
if "HERMES_API_OK" not in text:
print("[smoke] FAIL: terminal tool output not present in the answer", flush=True)
return 1
print("[smoke] PASS: agent ran a real terminal tool through the API server", flush=True)
return 0
except Exception as exc:
print(f"[smoke] request failed: {type(exc).__name__}: {exc}", flush=True)
return 1
try:
return asyncio.run(run())
finally:
try:
asyncio.run(adapter.disconnect())
except Exception:
pass
if __name__ == "__main__":
sys.exit(main())
+697
View File
@@ -0,0 +1,697 @@
#!/usr/bin/env python3
"""
Unit tests for the pr-queue-worker upstream fork auto-sync section.
Run: python3 scripts/test_pr_queue_sync.py
No network, no GitHub token, no real git: `gh_api`, `_sync_git`, the Claude
runner and the push helper are monkeypatched so the worker's *orchestration*
(merge path, conflict path, protected-branch path, CI verify/revert, gating and
state bookkeeping) is exercised deterministically. The git mechanics themselves
are covered by the live E2E (`--sync-only <repo> --dry`), not here.
"""
import importlib.util
import json
import pathlib
import subprocess
import sys
import tempfile
import time
HERE = pathlib.Path(__file__).resolve().parent
def load_worker():
spec = importlib.util.spec_from_file_location("pr_queue_worker", HERE / "pr-queue-worker.py")
mod = importlib.util.module_from_spec(spec)
spec.loader.exec_module(mod)
return mod
W = load_worker()
_real_sync_finish_merge = W._sync_finish_merge
PASSED = []
FAILED = []
def check(name, cond, detail=""):
(PASSED if cond else FAILED).append(name)
print((" PASS " if cond else " FAIL ") + name + ("" if cond else f" ← {detail}"))
def cp(args, code=0, out="", err=""):
return subprocess.CompletedProcess(args, code, out, err)
def make_state_file(tmpdir):
"""Point the worker's sync state at a temp file so tests never touch /tmp."""
W.SYNC_STATE_FILE = pathlib.Path(tmpdir) / "sync-state.json"
W.SYNC_TMP_BASE = pathlib.Path(tmpdir) / "sync-work"
W.sync_config # noqa: B018 — keep the reference obvious for readers
# ── 1. compare-API parsing ────────────────────────────────────────────────
def test_upstream_status_parsing():
print("1. upstream_status parses ahead_by/behind_by/tip")
calls = []
def fake_gh(method, path, token=None, json_data=None, retries=3):
calls.append(path)
return 200, {
"ahead_by": 4, "behind_by": 26,
"commits": [{"sha": "aaa"}, {"sha": "bbb"}, {"sha": "ccc"}, {"sha": "4eafc064"}],
}
W.gh_api = fake_gh
info = W.upstream_status("tok", "asepharyana/shiro-neko", "zakirkun/shiro-neko", "main", "main")
check("merge_count is ahead_by", info == (4, 26, "4eafc064"), str(info))
check("single compare call", len(calls) == 1, str(calls))
check("compare path uses owner:branch head (not owner/repo:branch)",
calls[0] == "/repos/asepharyana/shiro-neko/compare/main...zakirkun:main", str(calls))
def failing_gh(method, path, token=None, json_data=None, retries=3):
return 404, {"message": "Not Found"}
W.gh_api = failing_gh
check("unavailable compare → None", W.upstream_status("tok", "f", "p", "main", "main") is None)
# ── 2. gating: same upstream tip / interval not due ───────────────────────
def test_gating(tmpdir):
print("2. run_upstream_sync gating (interval + same upstream tip)")
make_state_file(tmpdir)
attempts = []
orig_list_forks = W.list_fork_repos
W.list_fork_repos = lambda: [("tok", "asepharyana/shiro-neko", "zakirkun/shiro-neko", "main")]
def fake_gh(method, path, token=None, json_data=None, retries=3):
if "/compare/" in path:
return 200, {"ahead_by": 4, "behind_by": 26, "commits": [{"sha": "up1"}]}
if path.startswith("/repos/asepharyana/shiro-neko/pulls"):
return 200, []
if path.endswith("/repos/asepharyana/shiro-neko"):
return 200, {"fork": True, "parent": {"full_name": "zakirkun/shiro-neko",
"default_branch": "main"},
"default_branch": "main"}
return 200, {}
W.gh_api = fake_gh
W.post_sync_discord = lambda *a, **k: True
orig_sync = W.sync_fork_repo
def fake_sync(token, fork, parent, local_branch, upstream_branch, upstream_sha,
merge_count, divergence, state, cfg, dry=False):
# mirror what the real function records so the gating is exercised
attempts.append((upstream_sha, dry))
entry = W._sync_entry(state, fork)
entry["last_sync_ts"] = time.time()
entry["last_attempt_sha"] = upstream_sha
W.save_sync_state(state)
return "synced", "fake"
W.sync_fork_repo = fake_sync
lines = W.run_upstream_sync()
check("first tick attempts the sync", len(attempts) == 1, str(lines))
lines = W.run_upstream_sync()
check("second tick not attempted (same upstream tip)", len(attempts) == 1, str(lines))
# upstream moves, but the interval has not elapsed → still no attempt
def fake_gh2(method, path, token=None, json_data=None, retries=3):
if "/compare/" in path:
return 200, {"ahead_by": 5, "behind_by": 26, "commits": [{"sha": "up2"}]}
if path == "/repos/asepharyana/shiro-neko":
return 200, {"fork": True, "parent": {"full_name": "zakirkun/shiro-neko",
"default_branch": "main"},
"default_branch": "main"}
return 200, []
W.gh_api = fake_gh2
lines = W.run_upstream_sync()
check("interval gate blocks a fresh retry", len(attempts) == 1, str(lines) + str(attempts))
# backdate the last attempt → the new upstream tip is picked up
st = json.loads(W.SYNC_STATE_FILE.read_text())
st["asepharyana/shiro-neko"]["last_sync_ts"] = time.time() - 2 * 3600
W.SYNC_STATE_FILE.write_text(json.dumps(st))
W.run_upstream_sync()
check("new upstream tip attempts again once the interval elapsed",
[a[0] for a in attempts] == ["up1", "up2"], str(attempts))
W.sync_fork_repo = orig_sync # later tests exercise the real implementation
W.list_fork_repos = orig_list_forks
# ── 3. clean merge → push → pending_verify ────────────────────────────────
def _install_git_fake(merge_code=0, unmerged=None):
"""Fake `git` for sync_fork_repo: clone/config/rev-parse/fetch/merge."""
state = {"head": "pre" + "0" * 37, "merges": [], "aborts": 0}
def fake_git(args, cwd=None, timeout=180):
a = [str(x) for x in args]
if a[0] == "clone":
return cp(a)
if a[0] == "rev-parse":
return cp(a, 0, state["head"] + "\n")
if a[0] == "merge":
if "--abort" in a:
state["aborts"] += 1
return cp(a)
state["merges"].append(a)
if merge_code == 0:
state["head"] = "merge" + "1" * 36
return cp(a, merge_code, "", "CONFLICT" if merge_code else "")
if a[0] == "diff":
# the merge diff (used for the quality pass) lists files; the
# unmerged listing is served by the monkeypatched _sync_unmerged_files
return cp(a, 0, "src/a.ts\nsrc/b.ts\n")
if a[0] == "status":
return cp(a, 0, "")
return cp(a)
W._sync_git = fake_git
W._sync_unmerged_files = lambda workdir: list(unmerged or [])
# Reset the marker guard too: tests that stub it out must not leak into the
# next test (a leftover stub silently disabled the commit guard).
W._sync_has_conflict_markers = lambda workdir: []
# Reset _sync_finish_merge to the real implementation. Test 4 stubs it with
# a fake that always succeeds — a leaked copy turns a FAILED resolution
# (test 5, 15b) into a bogus salvage and hides the skip/abort behavior.
W._sync_finish_merge = _real_sync_finish_merge
return state
def test_clean_merge_synced(tmpdir):
print("3. clean merge pushes and records pending_verify")
make_state_file(tmpdir)
state = {}
gitstate = _install_git_fake(merge_code=0, unmerged=[])
claude_calls = []
W._run_claude_sync = lambda workdir, prompt, label, fork, dry=False: (claude_calls.append(label), (True, "ok"))[1]
W._sync_commit_if_dirty = lambda workdir, msg: False
pushes = []
def fake_push(workdir, fork, source, dest, app_token, force=False):
pushes.append((source, dest, force))
return True, "pat push ok", False
W._push_ref = fake_push
res, detail = W.sync_fork_repo("tok", "asepharyana/shiro-neko", "zakirkun/shiro-neko",
"main", "main", "up1", 4, 26, state, W.sync_config("x"))
entry = state["asepharyana/shiro-neko"]
check("status synced", res == "synced", f"{res} {detail}")
check("pushed to the local branch", pushes and pushes[0][1] == "refs/heads/main", str(pushes))
check("pending_verify records merge sha", entry["pending_verify"]["sha"] == gitstate["head"], str(entry))
check("pending_verify records pre_merge sha", entry["pending_verify"]["pre_merge_sha"].startswith("pre"), str(entry))
check("last_merged_upstream_sha recorded", entry["last_merged_upstream_sha"] == "up1", str(entry))
check("clean merge gets a quality pass", claude_calls == ["hermes_sync_quality"], str(claude_calls))
def test_dry_run_is_pure(tmpdir):
print("3b. --dry never writes state, never posts Discord, never pushes")
# NOTE: the dry-path asserts `state == {}` — under the hood the worker builds
# a NEW empty state dict for dry runs (run_upstream_sync sets state={});
# sync_fork_repo itself also refuses to mutate state in dry mode. The unit
# test calls sync_fork_repo directly, so it asserts against a pre-seeded
# dict to catch any write through that seam.
make_state_file(tmpdir)
state = {}
_install_git_fake(merge_code=0, unmerged=[])
W._run_claude_sync = lambda workdir, prompt, label, fork, dry=False: (True, "ok")
W._sync_commit_if_dirty = lambda workdir, msg: False
pushes = []
def fake_push(workdir, fork, source, dest, app_token, force=False):
pushes.append(dest)
return True, "pat push ok", False
W._push_ref = fake_push
before = dict(state)
res, detail = W.sync_fork_repo("tok", "asepharyana/shiro-neko", "zakirkun/shiro-neko",
"main", "main", "up1", 4, 26, state, W.sync_config("x"), dry=True)
check("dry returns 'dry'", res == "dry", f"{res} {detail}")
check("dry never pushes", not pushes, str(pushes))
check("dry never writes state", state == before, f"{state} vs {before}")
# conflict path in dry: failed resolution must NOT write state either
state = {}
_install_git_fake(merge_code=1, unmerged=["src/tools.ts"])
W._run_claude_sync = lambda workdir, prompt, label, fork, dry=False: (False, "[INFRA] timed out")
before = dict(state)
res, detail = W.sync_fork_repo("tok", "f/x", "up/x", "main", "main", "up1", 4, 26, state,
W.sync_config("x"), dry=True)
check("dry conflict failure returns conflict-failed", res == "conflict-failed", f"{res} {detail}")
check("dry conflict failure writes no state", state == before, f"{state} vs {before}")
# ── 4. conflicted merge resolved by Claude ────────────────────────────────
def test_conflict_resolved(tmpdir):
print("4. conflicted merge handed to Claude Code, then pushed")
make_state_file(tmpdir)
state = {}
_install_git_fake(merge_code=1, unmerged=["src/tools.ts", "src/ui/App.tsx"])
labels = []
def fake_claude(workdir, prompt, label, fork, dry=False):
labels.append(label)
# after resolution the tree is clean → _sync_finish_merge must be called
W._sync_unmerged_files = lambda w: []
check("conflict prompt forbids --ours/--theirs",
"--ours/--theirs" in prompt and "rebase" in prompt)
return True, "resolved"
W._run_claude_sync = fake_claude
finished = {"n": 0}
# _install_git_fake defaults unmerged=[]; test 4's fake_claude flips it to []
# mid-run — reset after the test so the leak does not poison test 5.
# (test 5 deliberately runs a FAILED resolution and must see the merge
# still in conflict, not a bogus salvage.)
def fake_finish(workdir):
finished["n"] += 1
return True, ""
W._sync_finish_merge = fake_finish
W._push_ref = lambda *a, **k: (True, "pat push ok", False)
res, detail = W.sync_fork_repo("tok", "f/x", "up/x", "main", "main", "up1", 4, 26, state, W.sync_config("x"))
check("status synced", res == "synced", f"{res} {detail}")
check("conflict runner used", labels == ["hermes_sync_conflicts"], str(labels))
check("merge completed once", finished["n"] == 1, str(finished))
check("resolution noted in detail", "resolved 2 conflict" in detail, detail)
# Reset the fakes: fake_finish + the unmerged flip leak into test 5.
_install_git_fake()
def test_conflict_failed_skips_and_dedupes(tmpdir):
print("5. failed conflict resolution → skip once, no retry at same upstream tip")
make_state_file(tmpdir)
state = {}
_install_git_fake(merge_code=1, unmerged=["src/tools.ts"])
W._run_claude_sync = lambda *a, **k: (False, "[INFRA] Hermes API server timed out")
W._push_ref = lambda *a, **k: (_ for _ in ()).throw(AssertionError("must not push after failed resolution"))
res, detail = W.sync_fork_repo("tok", "f/x", "up/x", "main", "main", "up1", 4, 26, state, W.sync_config("x"))
entry = state["f/x"]
check("status conflict-failed", res == "conflict-failed", f"{res} {detail}")
check("upstream tip recorded as attempted", entry["last_attempt_sha"] == "up1", str(entry))
check("skip reason recorded", "timed out" in entry.get("skip_reason", ""), str(entry))
check("pending_verify not set", not entry.get("pending_verify"), str(entry))
# ── 6. protected branch → PR path ─────────────────────────────────────────
def test_protected_branch_opens_pr(tmpdir):
print("6. protected branch falls back to an upstream-sync PR")
make_state_file(tmpdir)
state = {}
_install_git_fake(merge_code=0, unmerged=[])
W._run_claude_sync = lambda *a, **k: (True, "ok")
W._sync_commit_if_dirty = lambda *a, **k: False
pushes = []
def fake_push(workdir, fork, source, dest, app_token, force=False):
pushes.append(dest)
if dest.endswith("refs/heads/main"):
return False, "pat: remote: error: GH006 protected branch", True
return True, "pat push ok", False
W._push_ref = fake_push
W.open_sync_pr = lambda *a, **k: 42
res, detail = W.sync_fork_repo("tok", "f/x", "up/x", "main", "main", "up1", 4, 26, state, W.sync_config("x"))
check("status pr-opened", res == "pr-opened", f"{res} {detail}")
check("direct push attempted first", pushes and pushes[0] == "refs/heads/main", str(pushes))
check("no pending_verify on the PR path", not state["f/x"].get("pending_verify"), str(state["f/x"]))
# ── 7. CI verify / auto-revert ────────────────────────────────────────────
def test_verify_green_clears(tmpdir):
print("7. verify_pending_syncs: green CI clears the watch")
make_state_file(tmpdir)
state = {"f/x": {"pending_verify": {"sha": "abc", "pre_merge_sha": "pre", "branch": "main",
"pushed_at": time.time()}}}
def fake_gh(method, path, token=None, json_data=None, retries=3):
if "/commits/main" in path:
return 200, [{"sha": "abc"}]
if path.endswith("/check-runs"):
return 200, {"check_runs": [{"name": "build", "status": "completed", "conclusion": "success"}]}
return 200, {}
W.gh_api = fake_gh
reverted = []
W._sync_revert_merge = lambda *a, **k: (reverted.append(a), (True, "reverted"))[1]
lines = W.verify_pending_syncs(state, {"f/x": "tok"})
check("green verifies", any("verified green" in l for l in lines), str(lines))
check("watch cleared", state["f/x"]["pending_verify"] is None, str(state))
check("no revert on green", not reverted, str(reverted))
def test_verify_red_reverts(tmpdir):
print("8. verify_pending_syncs: red CI at our merge sha reverts it")
make_state_file(tmpdir)
state = {"f/x": {"pending_verify": {"sha": "abc", "pre_merge_sha": "pre", "branch": "main",
"pushed_at": time.time()}}}
def fake_gh(method, path, token=None, json_data=None, retries=3):
if "/commits/main" in path:
return 200, [{"sha": "abc"}]
if path.endswith("/check-runs"):
return 200, {"check_runs": [{"name": "build", "status": "completed", "conclusion": "failure"}]}
return 200, {}
W.gh_api = fake_gh
reverted = []
def fake_revert(token, fork, branch, pre_merge_sha, reason):
reverted.append((fork, branch, pre_merge_sha, reason))
return True, "reverted main to pre"
W._sync_revert_merge = fake_revert
W.post_sync_discord = lambda *a, **k: True
lines = W.verify_pending_syncs(state, {"f/x": "tok"})
check("revert invoked with the pre-merge sha",
reverted and reverted[0][2] == "pre" and reverted[0][1] == "main", str(reverted))
check("revert reported", any("reverted" in l for l in lines), str(lines))
check("watch cleared after revert", state["f/x"]["pending_verify"] is None, str(state))
def test_verify_never_reverts_foreign_commits(tmpdir):
print("9. verify_pending_syncs: never reverts when someone pushed on top")
make_state_file(tmpdir)
state = {"f/x": {"pending_verify": {"sha": "abc", "pre_merge_sha": "pre", "branch": "main",
"pushed_at": time.time()}}}
def fake_gh(method, path, token=None, json_data=None, retries=3):
if "/commits/main" in path:
return 200, [{"sha": "humancommit"}]
if path.endswith("/check-runs"):
return 200, {"check_runs": [{"name": "build", "status": "completed", "conclusion": "failure"}]}
return 200, {}
W.gh_api = fake_gh
reverted = []
W._sync_revert_merge = lambda *a, **k: (reverted.append(a), (True, "x"))[1]
lines = W.verify_pending_syncs(state, {"f/x": "tok"})
check("no revert when the tip moved", not reverted, str(reverted))
check("tip change reported", any("moved past our merge" in l for l in lines), str(lines))
check("watch cleared", state["f/x"]["pending_verify"] is None, str(state))
def test_verify_waits_for_running_ci(tmpdir):
print("10. verify_pending_syncs: waits while checks run, respects no-CI grace")
make_state_file(tmpdir)
state = {"f/x": {"pending_verify": {"sha": "abc", "pre_merge_sha": "pre", "branch": "main",
"pushed_at": time.time()}}}
def fake_gh(method, path, token=None, json_data=None, retries=3):
if "/commits/main" in path:
return 200, [{"sha": "abc"}]
if path.endswith("/check-runs"):
return 200, {"check_runs": [{"name": "build", "status": "in_progress"}]}
return 200, {}
W.gh_api = fake_gh
W.verify_pending_syncs(state, {"f/x": "tok"})
check("running CI keeps the watch", state["f/x"]["pending_verify"] is not None, str(state))
# no checks at all and young → still pending (check-runs lag)
def fake_gh_none(method, path, token=None, json_data=None, retries=3):
if "/commits/main" in path:
return 200, [{"sha": "abc"}]
return 200, {"check_runs": []}
W.gh_api = fake_gh_none
W.verify_pending_syncs(state, {"f/x": "tok"})
check("fresh no-CI merge stays pending", state["f/x"]["pending_verify"] is not None, str(state))
# old + no CI → stop watching
state["f/x"]["pending_verify"]["pushed_at"] = time.time() - 3600
W.verify_pending_syncs(state, {"f/x": "tok"})
check("stale no-CI merge stops the watch", state["f/x"]["pending_verify"] is None, str(state))
# ── 11. fork discovery ────────────────────────────────────────────────────
def test_list_fork_repos():
print("11. list_fork_repos returns only forks with a resolvable parent")
def fake_gh(method, path, token=None, json_data=None, retries=3):
if path == "/app/installations":
return 200, [{"id": 1}]
if path.startswith("/installation/repositories"):
return 200, {"repositories": [
{"full_name": "o/plain-repo", "fork": False},
{"full_name": "o/fork-a", "fork": True},
{"full_name": "o/fork-b", "fork": True},
]}
if path == "/repos/o/fork-a":
return 200, {"fork": True, "default_branch": "main", "parent": {"full_name": "up/a"}}
if path == "/repos/o/fork-b":
return 200, {"fork": True, "default_branch": "main"} # parent stripped
return 404, {}
W.gh_api = fake_gh
W.get_installation_token = lambda inst: "tok"
forks = W.list_fork_repos()
check("only the resolvable fork returned", forks == [("tok", "o/fork-a", "up/a", "main")], str(forks))
# ── 12. push-error classification ─────────────────────────────────────────
def test_push_error_classification():
print("12. push error classification")
check("GH006 → protected", W._is_protected_push_error(
"remote: error: GH006: Protected branch update failed for refs/heads/main."))
check("required status checks → protected", W._is_protected_push_error(
"remote: error: Required status check \"ci\" is expected."))
check("workflows permission detected", W._is_workflow_push_error(
"! [remote rejected] main -> main (refusing to allow a GitHub App to create or update workflow `.github/workflows/ci.yml` without `workflows` permission)"))
check("plain rejected push is not 'protected'", not W._is_protected_push_error(
"fatal: could not read Username for 'https://github.com'"))
# ── 13. per-repo config override ──────────────────────────────────────────
def test_sync_config_override():
print("13. per-repo config override merges over defaults")
W.UPSTREAM_SYNC["repos"] = {"o/fork": {"interval_h": 6, "verify_ci": False}}
cfg = W.sync_config("o/fork")
check("override applied", cfg["interval_h"] == 6 and cfg["verify_ci"] is False, str(cfg))
check("defaults preserved", cfg["resolve_conflicts"] is True, str(cfg))
check("repos key not leaked", "repos" not in cfg, str(cfg))
W.UPSTREAM_SYNC["repos"] = {}
# ── 14. Hermes API-server client ──────────────────────────────────────────
def test_hermes_api_client(tmpdir):
"""The worker's Hermes client must speak OpenAI chat-completions and map
failures to [INFRA] strings the skip logic understands. Uses a real local
HTTP server (no external network)."""
print("14. Hermes API-server client (real HTTP round-trip)")
import http.server
import threading
seen = {}
class Handler(http.server.BaseHTTPRequestHandler):
def do_POST(self):
length = int(self.headers.get("Content-Length") or 0)
body = json.loads(self.rfile.read(length) or b"{}")
seen["path"] = self.path
seen["auth"] = self.headers.get("Authorization", "")
seen["body"] = body
if body.get("messages", [{}])[-1].get("content") == "boom":
self.send_response(500)
self.send_header("Content-Type", "application/json")
self.end_headers()
self.wfile.write(b'{"error":{"message":"upstream exploded"}}')
return
payload = json.dumps({
"choices": [{"message": {"role": "assistant", "content": "resolved ok"}}]
}).encode()
self.send_response(200)
self.send_header("Content-Type", "application/json")
self.end_headers()
self.wfile.write(payload)
def log_message(self, *a):
pass
srv = http.server.HTTPServer(("127.0.0.1", 0), Handler)
port = srv.server_address[1]
t = threading.Thread(target=srv.serve_forever, daemon=True)
t.start()
try:
W.API_SERVER_URL = f"http://127.0.0.1:{port}/v1"
W._api_server_key_from_env = lambda: "test-key-0123456789"
ok, text = W._hermes_api_post("resolve these conflicts", tmpdir)
check("client posts to /v1/chat/completions", seen.get("path") == "/v1/chat/completions", str(seen.get("path")))
check("client sends bearer auth", seen.get("auth") == "Bearer test-key-0123456789", str(seen.get("auth")))
check("client sends openai messages shape",
seen.get("body", {}).get("messages", [{}])[0].get("role") == "system", str(seen.get("body"))[:200])
check("client caps turns via model_options",
seen.get("body", {}).get("model_options", {}).get("max_turns") == W.AI_FIX_MAX_TURNS,
str(seen.get("body", {}).get("model_options")))
check("client returns agent text", ok and text == "resolved ok", f"{ok} {text!r}")
ok2, err2 = W._hermes_api_post("boom", tmpdir)
check("HTTP error mapped to [INFRA]", (not ok2) and err2.startswith("[INFRA]") and "500" in err2, err2)
# missing key → INFRA, never a silent success
W._api_server_key_from_env = lambda: ""
saved = W.os.environ.pop("API_SERVER_KEY", None)
try:
ok3, err3 = W._hermes_api_post("x", tmpdir)
check("missing key is [INFRA]", (not ok3) and "API_SERVER_KEY" in err3, err3)
finally:
if saved is not None:
W.os.environ["API_SERVER_KEY"] = saved
# unreachable port → INFRA with guidance
W._api_server_key_from_env = lambda: "test-key-0123456789"
W.API_SERVER_URL = "http://127.0.0.1:9/v1"
ok4, err4 = W._hermes_api_post("x", tmpdir)
check("unreachable server is [INFRA]", (not ok4) and "unreachable" in err4, err4)
finally:
srv.shutdown()
srv.server_close()
W.API_SERVER_URL = "http://127.0.0.1:8642/v1"
# ── 15. salvage + marker guard ────────────────────────────────────────────
def test_session_header_sent(tmpdir):
"""X-Hermes-Session-Id must be sent so each fork gets a fresh transcript."""
print("17. X-Hermes-Session-Id is sent per fork")
captured = {}
class FakeResp:
status_code = 200
def json(self):
return {"choices": [{"message": {"content": "done"}}]}
import httpx as _httpx
import sys as _sys
class FakeClient:
def __init__(self, *a, **k):
pass
def __enter__(self):
return self
def __exit__(self, *a):
return False
def post(self, url, headers, json):
captured["headers"] = headers
captured["url"] = url
return FakeResp()
_sys.modules["httpx"] = type("H", (), {"Client": FakeClient})
ok, snippet = W._hermes_api_post("resolve", pathlib.Path(tmpdir), session_id="sync_x_y")
check("session header sent", captured["headers"].get("X-Hermes-Session-Id") == "sync_x_y",
str(captured.get("headers")))
# Without session_id the header must be absent.
captured.clear()
ok2, _ = W._hermes_api_post("x", pathlib.Path(tmpdir), session_id=None)
check("session header absent when not passed",
"X-Hermes-Session-Id" not in captured["headers"], str(captured.get("headers")))
_sys.modules["httpx"] = _httpx
# ── 15. salvage + marker guard ────────────────────────────────────────────
def test_salvage_on_agent_timeout(tmpdir):
"""A timed-out agent call must NOT throw away a merge the agent already
finished — resolving many conflicts legitimately exceeds the HTTP timeout."""
print("15. salvage a completed merge after an agent timeout")
make_state_file(tmpdir)
state = {}
gitstate = _install_git_fake(merge_code=1, unmerged=[]) # agent resolved everything
labels = []
# The merge reports conflicts (so the worker enters the conflict path), but
# by the time the agent call ends the agent HAS resolved everything — the
# listing flips to empty when the fake runner is invoked.
resolved = {"done": False}
def fake_runner(workdir, prompt, label, fork, dry=False):
labels.append(label)
resolved["done"] = True # agent finished the work…
return False, "[INFRA] Hermes API server timed out after 2700s" # …but the HTTP call timed out
W._run_claude_sync = fake_runner
W._sync_unmerged_files = lambda workdir: [] if resolved["done"] else ["src/tools.ts"]
W._sync_has_conflict_markers = lambda workdir: []
pushes = []
W._push_ref = lambda workdir, fork, source, dest, app_token, force=False: (
pushes.append(dest), (True, "pat push ok", False))[1]
res, detail = W.sync_fork_repo("tok", "asepharyana/shiro-neko", "zakirkun/shiro-neko",
"main", "main", "up1", 4, 26, state, W.sync_config("x"))
check("timeout after a finished merge is salvaged, not failed",
res == "synced", f"{res} {detail}")
check("salvage still pushes", pushes and pushes[0] == "refs/heads/main", str(pushes))
check("salvage note mentions the salvage", "salvag" in detail.lower(), detail)
# …but a genuinely unfinished merge still fails and aborts.
print("15b. unfinished merge after a timeout still fails")
make_state_file(tmpdir)
state2 = {}
gitstate2 = _install_git_fake(merge_code=1, unmerged=["src/tools.ts"])
W._sync_unmerged_files = lambda workdir: ["src/tools.ts"]
W._sync_has_conflict_markers = lambda workdir: ["src/tools.ts"]
res2, detail2 = W.sync_fork_repo("tok", "f/x", "up/x", "main", "main", "up1", 4, 26,
state2, W.sync_config("x"))
check("unfinished merge is still a failure", res2 == "conflict-failed", f"{res2} {detail2}")
check("unfinished merge is aborted", gitstate2["aborts"] >= 1, str(gitstate2))
def test_finish_merge_blocks_leftover_markers(tmpdir):
"""`git add`ed files that still carry markers must never be committed."""
print("16. _sync_finish_merge refuses files with leftover conflict markers")
make_state_file(tmpdir)
_install_git_fake() # reset fakes; test 15b leaves a leaky spy behind
W._sync_unmerged_files = lambda workdir: []
W._sync_has_conflict_markers = lambda workdir: ["src/App.tsx"]
commits = []
real_git = W._sync_git
def git_spy(args, workdir, timeout):
if str(args[0]) == "commit":
commits.append(list(args))
return real_git(args, workdir, timeout)
W._sync_git = git_spy
ok, why = W._sync_finish_merge(pathlib.Path(tmpdir))
check("marker guard blocks the commit", (not ok) and "marker" in why, f"{ok} {why}")
check("no commit attempted", not commits, str(commits))
W._sync_git = real_git
W._sync_has_conflict_markers = lambda workdir: []
W._sync_unmerged_files = lambda workdir: []
def main():
with tempfile.TemporaryDirectory() as tmpdir:
test_upstream_status_parsing()
test_gating(tmpdir)
test_clean_merge_synced(tmpdir)
test_dry_run_is_pure(tmpdir)
test_conflict_resolved(tmpdir)
test_conflict_failed_skips_and_dedupes(tmpdir)
test_protected_branch_opens_pr(tmpdir)
test_verify_green_clears(tmpdir)
test_verify_red_reverts(tmpdir)
test_verify_never_reverts_foreign_commits(tmpdir)
test_verify_waits_for_running_ci(tmpdir)
test_list_fork_repos()
test_push_error_classification()
test_sync_config_override()
test_hermes_api_client(pathlib.Path(tmpdir))
test_session_header_sent(tmpdir)
test_salvage_on_agent_timeout(tmpdir)
test_finish_merge_blocks_leftover_markers(tmpdir)
print(f"\n{len(PASSED)} passed, {len(FAILED)} failed")
if FAILED:
print("failed: " + ", ".join(FAILED))
return 1 if FAILED else 0
if __name__ == "__main__":
sys.exit(main())
+33 -2
View File
@@ -115,9 +115,9 @@ export async function handleWebhook(
env.discordWebhookUrl, env.discordWebhookUrl,
`**${owner}/${repo}** PR #${pr.number} reviewed` + `**${owner}/${repo}** PR #${pr.number} reviewed` +
(result.data && result.data["review"] && (result.data["review"] as Record<string, unknown>)["score"] (result.data && result.data["review"] && (result.data["review"] as Record<string, unknown>)["score"]
? ` — score ${(result.data["review"] as Record<string, unknown>)["score"]}/10` ? ` — score ${(result.data["review"] as Record<string, unknown>)["score"]}/100`
: "") + : "") +
`\n${result.markdown.slice(0, 4000)}`, `\n${htmlToDiscordPlain(result.markdown).slice(0, 4000)}`,
"✅ PR-Agent Review Complete", "✅ PR-Agent Review Complete",
); );
} }
@@ -147,6 +147,37 @@ async function getHttpx() {
return fetch; return fetch;
} }
/** Strip HTML table markup down to Discord-friendly plain text.
* Discord embeds render limited markdown — raw <table>/<td>/<tr> tags
* would show as literal HTML. Convert the reviewer table into lines. */
function htmlToDiscordPlain(html: string): string {
let s = html
.replace(/<details>/g, "")
.replace(/<\/details>/g, "")
.replace(/<summary>/g, "▶ ")
.replace(/<\/summary>/g, "\n")
.replace(/<br\s*\/?>/gi, "\n")
.replace(/<\/tr>/gi, "\n")
.replace(/<\/td>/gi, "")
.replace(/<\/th>/gi, "")
.replace(/<td[^>]*>/gi, "")
.replace(/<th[^>]*>/gi, "")
.replace(/<tr[^>]*>/gi, "")
.replace(/<table[^>]*>/gi, "")
.replace(/<\/table>/gi, "")
.replace(/<li[^>]*>/gi, "• ")
.replace(/<[^>]+>/g, "")
.replace(/&nbsp;/g, " ")
.replace(/&amp;/g, "&")
.replace(/&lt;/g, "<")
.replace(/&gt;/g, ">")
.replace(/&quot;/g, '"')
.replace(/&#39;/g, "'")
.replace(/\n{3,}/g, "\n\n")
.trim();
return s;
}
async function sendDiscord(webhook: string, content: string, title?: string): Promise<void> { async function sendDiscord(webhook: string, content: string, title?: string): Promise<void> {
try { try {
await fetch(webhook, { await fetch(webhook, {