asepharyana
f156fc0c9e
The live pipe (yt-dlp -o - -> ffmpeg) delivers data at network speed with unreliable PTS, which defeats ffmpeg -re and made x264 -r 30 force-duplicate held frames -> ~1fps video (the patah-patah symptom). Per user suggestion, download the FULL clip to a temp file first (downloadScreenInput), then feed that FILE PATH to prepareStream. String inputs already get -re, so the encoder now paces cleanly at 1x against a monotonic-PTS file — proven reliable in local tests (vs the live pipe which always bursted). Temp file is removed on stream end / stop. - getDirectScreenInput -> downloadScreenInput (returns file path) - resolveInputWithRetry now awaits a completed file + retries on failure - screenShareController.stops/cleanup removes the per-run tmpdir - screenShareInput.test.ts updated to the file-download contract
117 lines
4.5 KiB
TypeScript
117 lines
4.5 KiB
TypeScript
// ═══════════════════════════════════════════════════════════════════════════════
|
|
// Screen share input resolution tests
|
|
//
|
|
// downloadScreenInput downloads the FULL merged video+audio media to a temp
|
|
// file first (yt-dlp `-o <tmpdir>/media.%(ext)s`), then returns the file
|
|
// path. Feeding a FILE path (not a live stdout pipe) to prepareStream is
|
|
// what makes ffmpeg `-re` pacing reliable — a pipe has unreliable PTS and
|
|
// caused the ~1fps force-duplication symptom.
|
|
//
|
|
// yt-dlp is faked via a PATH shim script so the test does not hit the
|
|
// network or need real binaries.
|
|
// ═══════════════════════════════════════════════════════════════════════════════
|
|
|
|
import {
|
|
chmodSync,
|
|
mkdtempSync,
|
|
readFileSync,
|
|
rmSync,
|
|
writeFileSync,
|
|
} from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { afterAll, beforeAll, describe, expect, it } from "vitest";
|
|
|
|
import { downloadScreenInput } from "../src/modules/voice-recording/mediaSource.js";
|
|
|
|
// ─── fake bin dir ──────────────────────────────────────────────────────────────
|
|
let fakeBinDir: string | null = null;
|
|
const realPath = process.env.PATH;
|
|
|
|
// Bash shim: find the -o pattern, substitute the extension, write 4096 bytes.
|
|
// Escaped as a separate string to keep the TS template literal simple.
|
|
const ytShimBody = `prev=""
|
|
out=""
|
|
for a in "$@"; do
|
|
if [ "$prev" = "-o" ]; then out="$a"; fi
|
|
prev="$a"
|
|
done
|
|
if [ "$GMW_FAKE_YTDLP_FAIL" = "1" ]; then
|
|
echo "ERROR: [youtube] ...: 403 Forbidden (access denied)" >&2
|
|
exit 8
|
|
fi
|
|
target=$(printf '%s' "$out" | sed 's/%(ext)s/.mp4/')
|
|
head -c 4096 /dev/urandom > "$target"
|
|
exit 0
|
|
`;
|
|
const ytShim = `#!/usr/bin/env bash\n${ytShimBody}`;
|
|
|
|
const ytShimDump = `#!/usr/bin/env bash
|
|
printf '%s\\n' "$*" >> "$GMW_FAKE_YTDLP_DUMP_ARGS"
|
|
${ytShimBody}
|
|
`;
|
|
|
|
beforeAll(() => {
|
|
fakeBinDir = mkdtempSync(join(tmpdir(), "gmw-fake-bins-"));
|
|
writeFileSync(join(fakeBinDir, "yt-dlp"), ytShim);
|
|
chmodSync(join(fakeBinDir, "yt-dlp"), 0o755);
|
|
process.env.PATH = `${fakeBinDir}:${process.env.PATH}`;
|
|
});
|
|
|
|
afterAll(() => {
|
|
if (fakeBinDir) {
|
|
rmSync(fakeBinDir, { recursive: true, force: true });
|
|
}
|
|
process.env.PATH = realPath;
|
|
});
|
|
|
|
// ─── tests ─────────────────────────────────────────────────────────────────────
|
|
describe("downloadScreenInput", () => {
|
|
it("downloads media to a temp file and returns its path", async () => {
|
|
const mediaPath = await downloadScreenInput("https://youtu.be/abc");
|
|
expect(typeof mediaPath).toBe("string");
|
|
expect(mediaPath).toMatch(/gmw-ytdlp-/);
|
|
const size = readFileSync(mediaPath).length;
|
|
expect(size).toBeGreaterThan(0);
|
|
// The fake yt-dlp writes 4096 bytes → the file must deliver them.
|
|
expect(size).toBe(4096);
|
|
});
|
|
|
|
it("rejects when yt-dlp fails (transient 403) so the controller retries", async () => {
|
|
process.env.GMW_FAKE_YTDLP_FAIL = "1";
|
|
try {
|
|
await expect(downloadScreenInput("https://youtu.be/abc")).rejects.toThrow(
|
|
/403|exit 8|failed/i,
|
|
);
|
|
} finally {
|
|
delete process.env.GMW_FAKE_YTDLP_FAIL;
|
|
}
|
|
});
|
|
|
|
it("passes a file -o pattern (NOT `-o -`) to yt-dlp", async () => {
|
|
const argsDump = join(
|
|
tmpdir(),
|
|
`gmw-ytargs-${process.pid}-${Date.now()}.txt`,
|
|
);
|
|
process.env.GMW_FAKE_YTDLP_DUMP_ARGS = argsDump;
|
|
const realPath2 = process.env.PATH;
|
|
const dir = fakeBinDir as unknown as string;
|
|
const existing = join(dir, "yt-dlp");
|
|
writeFileSync(existing, ytShimDump);
|
|
chmodSync(existing, 0o755);
|
|
try {
|
|
const mediaPath = await downloadScreenInput("https://youtu.be/abc");
|
|
expect(readFileSync(mediaPath).length).toBeGreaterThan(0);
|
|
await new Promise((r) => setTimeout(r, 100));
|
|
const args = readFileSync(argsDump, "utf8").trim();
|
|
expect(args).not.toContain("-o -");
|
|
expect(args).toContain("-o ");
|
|
expect(args).toMatch(/gmw-ytdlp-/);
|
|
} finally {
|
|
delete process.env.GMW_FAKE_YTDLP_DUMP_ARGS;
|
|
rmSync(argsDump, { force: true });
|
|
process.env.PATH = realPath2;
|
|
}
|
|
});
|
|
});
|