Root cause: scanExistingStreamers only read channel.members, which is
EMPTY after a gateway restart because the selfbot's guild member cache
hasn't been populated yet. So any user who was ALREADY on camera /
screen-sharing when the bot (re)joined was never detected → no video.
Fix: when the member cache is empty, fall back to guild.members.fetch()
(REST GET /guilds/{id}/members — user-token compatible; the bot-only
GET /channels/{id}/voice-states returns 404 for selfbots, verified live)
which populates member.voice states, then re-scan channel.members for
streaming/selfVideo.
- scanExistingStreamers is now async; trackChannel fire-and-forgets it
- logs source=cache vs source=rest-members for observability
- +1 test: cold-start channel.members empty → REST fetch → watch camera user
- 191/191 tests pass, typecheck + build + biome clean
194 lines
6.3 KiB
TypeScript
194 lines
6.3 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
import * as streamWatch from "../src/modules/voice-recording/streamWatchReceiver.js";
|
|
import {
|
|
__resetVideoRecorderState,
|
|
setVideoRecorderClient,
|
|
setVideoRecordingsDir,
|
|
startVideoRecording,
|
|
stopVideoRecording,
|
|
trackChannel,
|
|
untrackChannel,
|
|
} from "../src/modules/voice-recording/videoRecorder.js";
|
|
|
|
// ─── mocks ─────────────────────────────────────────────────────────────
|
|
function makeChannel(guildId = "g1", channelId = "c1") {
|
|
return {
|
|
id: channelId,
|
|
guild: {
|
|
id: guildId,
|
|
members: { fetch: vi.fn().mockResolvedValue(new Map()) },
|
|
},
|
|
};
|
|
}
|
|
|
|
function makeClient() {
|
|
return {
|
|
user: { id: "bot1" },
|
|
on: vi.fn(),
|
|
};
|
|
}
|
|
|
|
let seq = 0;
|
|
function makeUser() {
|
|
seq += 1;
|
|
return `user-${seq}`;
|
|
}
|
|
|
|
beforeEach(() => {
|
|
__resetVideoRecorderState();
|
|
vi.restoreAllMocks();
|
|
setVideoRecordingsDir("/tmp/gmw-vidrec-test");
|
|
});
|
|
|
|
describe("videoRecorder (stream-watch orchestration)", () => {
|
|
it("registers a voiceStateUpdate + raw listener on the client (idempotent)", () => {
|
|
const client = makeClient();
|
|
setVideoRecorderClient(client);
|
|
setVideoRecorderClient(client); // idempotent (videoRecorder + streamWatch)
|
|
// one raw (streamWatch) + one voiceStateUpdate (videoRecorder)
|
|
expect(client.on).toHaveBeenCalledTimes(2);
|
|
expect(client.on).toHaveBeenCalledWith(
|
|
"voiceStateUpdate",
|
|
expect.any(Function),
|
|
);
|
|
expect(client.on).toHaveBeenCalledWith("raw", expect.any(Function));
|
|
});
|
|
|
|
it("startVideoRecording delegates to streamWatchReceiver.startStreamWatch", () => {
|
|
const spy = vi
|
|
.spyOn(streamWatch, "startStreamWatch")
|
|
.mockImplementation(() => {});
|
|
const ch = makeChannel();
|
|
startVideoRecording(ch, makeUser());
|
|
expect(spy).toHaveBeenCalledWith(ch, expect.any(String));
|
|
});
|
|
|
|
it("refuses to record the bot's own video", () => {
|
|
setVideoRecorderClient(makeClient());
|
|
const spy = vi
|
|
.spyOn(streamWatch, "startStreamWatch")
|
|
.mockImplementation(() => {});
|
|
startVideoRecording(makeChannel(), "bot1");
|
|
expect(spy).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("stopVideoRecording calls streamWatchReceiver.stopStreamWatch", () => {
|
|
const spy = vi
|
|
.spyOn(streamWatch, "stopStreamWatch")
|
|
.mockImplementation(() => {});
|
|
const u = makeUser();
|
|
stopVideoRecording("g1", u);
|
|
expect(spy).toHaveBeenCalledWith("g1", u);
|
|
});
|
|
|
|
it("untrackChannel tears down all stream watches for the guild", () => {
|
|
const spy = vi
|
|
.spyOn(streamWatch, "stopAllStreamWatches")
|
|
.mockImplementation(() => {});
|
|
untrackChannel("g1");
|
|
expect(spy).toHaveBeenCalledWith("g1");
|
|
});
|
|
|
|
it("the voiceStateUpdate handler starts a watch when a member starts streaming", () => {
|
|
const client = makeClient() as any;
|
|
setVideoRecorderClient(client);
|
|
trackChannel("g1", makeChannel());
|
|
const startSpy = vi
|
|
.spyOn(streamWatch, "startStreamWatch")
|
|
.mockImplementation(() => {});
|
|
const listener = client.on.mock.calls.find(
|
|
(c: unknown[]) => c[0] === "voiceStateUpdate",
|
|
)?.[1];
|
|
listener(null, {
|
|
id: "u1",
|
|
guild: { id: "g1" },
|
|
channelId: "c1",
|
|
streaming: true,
|
|
});
|
|
expect(startSpy).toHaveBeenCalled();
|
|
});
|
|
|
|
it("the voiceStateUpdate handler stops a watch when a member stops streaming", () => {
|
|
const client = makeClient() as any;
|
|
setVideoRecorderClient(client);
|
|
trackChannel("g1", makeChannel());
|
|
const stopSpy = vi
|
|
.spyOn(streamWatch, "stopStreamWatch")
|
|
.mockImplementation(() => {});
|
|
const listener = client.on.mock.calls.find(
|
|
(c: unknown[]) => c[0] === "voiceStateUpdate",
|
|
)?.[1];
|
|
listener(null, {
|
|
id: "u1",
|
|
guild: { id: "g1" },
|
|
channelId: "c1",
|
|
streaming: false,
|
|
});
|
|
expect(stopSpy).toHaveBeenCalledWith("g1", "u1");
|
|
});
|
|
|
|
it("trackChannel scans pre-existing streamers already in the channel (bot join case)", () => {
|
|
const client = makeClient() as any;
|
|
setVideoRecorderClient(client);
|
|
const spy = vi
|
|
.spyOn(streamWatch, "startStreamWatch")
|
|
.mockImplementation(() => {});
|
|
const ch = {
|
|
id: "c1",
|
|
guild: { id: "g1" },
|
|
members: new Map([
|
|
["u1", { id: "u1", voice: { streaming: true } }], // already streaming
|
|
["u2", { id: "u2", voice: { streaming: false } }], // not streaming
|
|
["bot1", { id: "bot1", voice: { streaming: true } }], // bot itself
|
|
]),
|
|
};
|
|
trackChannel("g1", ch as any);
|
|
// only the already-streaming non-bot member gets watched
|
|
expect(spy).toHaveBeenCalledTimes(1);
|
|
expect(spy).toHaveBeenCalledWith(ch, "u1");
|
|
});
|
|
|
|
it("trackChannel is a no-op when the channel has no members (or none streaming)", () => {
|
|
const spy = vi
|
|
.spyOn(streamWatch, "startStreamWatch")
|
|
.mockImplementation(() => {});
|
|
trackChannel("g1", makeChannel()); // no members
|
|
expect(spy).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("trackChannel falls back to REST guild.members.fetch() when cache is empty (cold start bug fix)", async () => {
|
|
const client = makeClient() as any;
|
|
setVideoRecorderClient(client);
|
|
const spy = vi
|
|
.spyOn(streamWatch, "startStreamWatch")
|
|
.mockImplementation(() => {});
|
|
// Warmable guild: members.fetch() populates channel.members with a
|
|
// camera-on member (selfVideo) — the cold-start scenario where the bot
|
|
// joins a channel that already has someone on camera but the member cache
|
|
// hasn't been populated yet.
|
|
const cameraMember = {
|
|
id: "u-cam",
|
|
voice: { streaming: false, selfVideo: true },
|
|
};
|
|
const ch = {
|
|
id: "c1",
|
|
guild: {
|
|
id: "g1",
|
|
members: {
|
|
fetch: vi.fn().mockImplementation(async () => {
|
|
// Simulate REST fetch populating the channel member cache.
|
|
(ch as any).members = new Map([["u-cam", cameraMember]]);
|
|
return new Map([["u-cam", cameraMember]]);
|
|
}),
|
|
},
|
|
},
|
|
members: new Map(), // empty at join time — cold cache
|
|
};
|
|
trackChannel("g1", ch as any);
|
|
// Allow the async scanExistingStreamers (fire-and-forget) to complete.
|
|
await vi.waitFor(() => {
|
|
expect(spy).toHaveBeenCalledWith(ch as any, "u-cam");
|
|
});
|
|
});
|
|
});
|