perf(golive): ffmpeg-spawn demuxer (no node-av) + E2E pipeline tests
Phase 2 — replace the 114MB node-av binary with a plain ffmpeg spawn:
Demuxer.ts: spool stream input to temp file → probe via ffmpeg stderr
(ffmpeg-headless ships NO ffprobe — parse 'Stream #0:0: Video: h264...
640x360, 30 fps' from -loglevel info) → ffmpeg -c copy -f h264 pipe:1
→ NAL-split frames. Falls back to h264 defaults when probe fails.
prepareStream.ts: resolve ffmpeg from FFMPEG_PATH env → Nix store
ffmpeg-headless (hash-prefixed entry!) → PATH; split encoder option
strings ('-forced-idr 1' → two argv) — fluent-ffmpeg used to split
automatically, spawn does not.
E2E tests (tsx, need LD_LIBRARY_PATH=/tmp/ldc-build):
- golive-demux-e2e.ts: real H264 file → 33 NAL frames + dims from probe
- golive-pipeline-e2e.ts: prepareStream → demux → 82 frames
- golive-videostream-e2e.ts: local peer pair → demux → VideoStream →
native setPacketizer/sendFrame/addTimestamp → 33 frames sent connected
Pitfalls captured: setPacketizer before negotiation breaks createOffer
('No DataChannel or Track to negotiate'); track methods are read-only
(no monkeypatching); both peers must declare audio+video tracks or
answer hangs; state() returns 'closed' after close() — snapshot first.
This commit is contained in:
@@ -9,6 +9,8 @@
|
||||
*/
|
||||
|
||||
import { type ChildProcess, spawn } from "node:child_process";
|
||||
import { existsSync, readdirSync } from "node:fs";
|
||||
import { join } from "node:path";
|
||||
import { PassThrough, type Readable } from "node:stream";
|
||||
import { demux } from "./Demuxer.js";
|
||||
import { type EncoderSettings, Encoders } from "./Encoders.js";
|
||||
@@ -37,6 +39,25 @@ const DEFAULT_HEADERS = {
|
||||
Connection: "keep-alive",
|
||||
};
|
||||
|
||||
/** Resolve ffmpeg binary (env override → PATH → Nix store ffmpeg-headless). */
|
||||
function resolveFfmpeg(): string {
|
||||
if (process.env.FFMPEG_PATH && existsSync(process.env.FFMPEG_PATH)) {
|
||||
return process.env.FFMPEG_PATH;
|
||||
}
|
||||
const store = "/nix/store";
|
||||
if (existsSync(store)) {
|
||||
const entries = readdirSync(store);
|
||||
for (const entry of entries) {
|
||||
if (!entry.includes("ffmpeg-headless-")) continue;
|
||||
const candidate = join(store, entry, "bin", "ffmpeg");
|
||||
if (existsSync(candidate)) return candidate;
|
||||
}
|
||||
}
|
||||
return "ffmpeg";
|
||||
}
|
||||
|
||||
const FFMPEG_BIN = resolveFfmpeg();
|
||||
|
||||
/**
|
||||
* prepareStream — build an ffmpeg command (as spawn args + PassThrough output)
|
||||
* that transcodes the input into a pipe we can demux. Mirrors @dank074's
|
||||
@@ -132,6 +153,11 @@ export function prepareStream(
|
||||
throw new Error(
|
||||
`Encoder settings not specified for ${mergedOptions.videoCodec}`,
|
||||
);
|
||||
// Encoder options are declared as single strings like "-forced-idr 1";
|
||||
// spawn needs each flag and value as separate argv entries.
|
||||
const encOptions = enc.options.flatMap((opt) =>
|
||||
opt.split(/\s+/).filter(Boolean),
|
||||
);
|
||||
args.push(
|
||||
"-b:v",
|
||||
`${mergedOptions.bitrateVideo}k`,
|
||||
@@ -147,8 +173,10 @@ export function prepareStream(
|
||||
"expr:gte(t,n_forced*1)",
|
||||
"-c:v",
|
||||
enc.name,
|
||||
...enc.options,
|
||||
...(enc.globalOptions ?? []),
|
||||
...encOptions,
|
||||
...(enc.globalOptions ?? []).flatMap((opt) =>
|
||||
opt.split(/\s+/).filter(Boolean),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -174,8 +202,8 @@ export function prepareStream(
|
||||
|
||||
const isUrl = typeof input === "string";
|
||||
const proc: ChildProcess = isUrl
|
||||
? spawn("ffmpeg", args, { stdio: ["ignore", "pipe", "pipe"] })
|
||||
: spawn("ffmpeg", args, { stdio: ["pipe", "pipe", "pipe"] });
|
||||
? spawn(FFMPEG_BIN, args, { stdio: ["ignore", "pipe", "pipe"] })
|
||||
: spawn(FFMPEG_BIN, args, { stdio: ["pipe", "pipe", "pipe"] });
|
||||
|
||||
if (proc.stdin && !isUrl) {
|
||||
input.on("data", (chunk: Buffer) => proc.stdin?.write(chunk));
|
||||
|
||||
Reference in New Issue
Block a user