fix(goLive): pace demuxer with -re + bounded frame-drop (was: audio patah, 8s lag)

Root cause (revisited): the previous gate paused proc.stdout when vPipe was
full. That stalled the SAME ffmpeg process that also writes audio on fd3, so
audio stuttered; and the ~8s backlog already built never drained → permanent
lag. Symptom: 'video still lags bad, now audio also choppy'.

Fix:
- spawn demuxer ffmpeg with -re for stream (pipe) input. Verified locally:
  a 5s NUT clip demuxes in 0.088s without -re (57x burst) vs 4.539s with -re
  (real-time). -re throttles the input read, which back-pressures the whole
  upstream chain (encoder x264 -> merge ffmpeg -> yt-dlp) through OS pipes,
  pinning production at 1x. No unbounded backlog.
- drop oldest queued frame when vPipe readableLength >= 30 (transient sender
  stall guard) instead of pausing stdout — keeps video fresh and audio intact.
- removed gateSource/sourcePaused entirely.

Audio and video now pace together at 1x; video is the newest frame, not an
8-second-old one.
This commit is contained in:
asepharyana
2026-08-13 12:41:49 +07:00
parent 60faaa9304
commit 6e7c4901c9
+35 -29
View File
@@ -171,6 +171,17 @@ export async function demux(
// stderr and are parsed for dimensions/fps. // stderr and are parsed for dimensions/fps.
"-loglevel", "-loglevel",
"info", "info",
// Real-time throttle: read piped input at 1x so the WHOLE upstream chain
// (encoder x264, merge ffmpeg, yt-dlp download) is paced by wall-clock,
// not by network/VOD speed. Without this the encoder bursts ~10x faster
// than real-time and the vPipe queue grows unboundedly — the WebRTC
// sender correctly paces 30fps but always emits the OLDEST buffered
// frame, so video freezes/lags while audio (small, jitter-buffer
// recoverable) stays smooth. Pausing proc.stdout instead (previous fix)
// stalled the same ffmpeg's fd3 audio too → audio stuttered AND the
// already-built backlog never drained. `-re` fixes production rate at
// source; a bounded backlog below still protects against sender stalls.
...(isStream ? ["-re"] : []),
// Input format hint: raw H264 has NO magic header, so ffmpeg's // Input format hint: raw H264 has NO magic header, so ffmpeg's
// auto-detection fails with "Invalid data found when processing input" // auto-detection fails with "Invalid data found when processing input"
// whenever the first bytes arrive late/buffered. Pin the demuxer input // whenever the first bytes arrive late/buffered. Pin the demuxer input
@@ -366,31 +377,18 @@ export async function demux(
// NALs and flush one frame per slice, prepending the parameter sets that // NALs and flush one frame per slice, prepending the parameter sets that
// precede it, and timestamp it as ONE frame at the video frame rate. // precede it, and timestamp it as ONE frame at the video frame rate.
// BACKPRESSURE: the encoder (prepareStream ffmpeg) produces frames at the // PACING: ffmpeg is spawned with `-re` (see spawn args) so it reads the
// download/CPU rate, which for a fast VOD is ~10x real-time. The sender // piped NUT input at 1x wall-clock. That back-pressures the whole upstream
// (BaseMediaStream) paces at 30fps. Without a gate, the demuxer buffers an // chain (encoder x264 → merge ffmpeg → yt-dlp download) through their OS
// unbounded backlog and the sender always emits the OLDEST frames → the // pipes, pinning production at real-time — the old design (no throttle)
// viewer sees frozen/laggy video while audio (tiny, jitter-buffer // had the encoder burst ~10x faster than the 30fps WebRTC sender, so the
// recoverable) stays smooth. That is the "video stuck, voice normal" // demuxer buffered an unbounded backlog and the sender always emitted the
// symptom. So we propagate vPipe backpressure UP to the demuxer's ffmpeg // OLDEST frames → frozen/laggy video while audio (tiny, jitter-buffer
// stdout: when vPipe is full we pause it, which stalls the demuxer, which // recoverable) stayed smooth. That is the "video stuck, voice normal"
// stalls its stdin, which back-pressures the encoder, pinning the whole // symptom. The first fix paused proc.stdout when vPipe was full, but that
// pipeline to 1x. This is the real-time throttle for the streaming path // stalled fd3 audio too (same process) → audio patah-patah, and the
// (-re only works for file/URL inputs; screen share is always a pipe). // accumulated backlog never drained → permanent ~8s lag. `-re` + bounded
let sourcePaused = false; // drop is the correct throttle.
const gateSource = (ok: boolean) => {
if (!ok && !sourcePaused) {
sourcePaused = true;
proc.stdout?.pause();
}
};
vPipe.on("drain", () => {
if (sourcePaused) {
sourcePaused = false;
proc.stdout?.resume();
}
});
let videoBuf = Buffer.alloc(0); let videoBuf = Buffer.alloc(0);
let frameCount = 0; let frameCount = 0;
let pendingNals: Buffer[] = []; let pendingNals: Buffer[] = [];
@@ -414,7 +412,18 @@ export async function demux(
pendingNals = []; pendingNals = [];
pendingHasSlice = false; pendingHasSlice = false;
pendingIsKey = false; pendingIsKey = false;
const ok = vPipe.write({ // Bounded backlog: if the sender ever stalls (slow network, CPU spike),
// drop the oldest queued frame instead of letting vPipe grow. The
// WebRTC sender paces 30fps from the newest frames; ffmpeg's `-re` (see
// spawn args) keeps production at 1x so this only triggers on stalls —
// never during normal playback. Without it, a transient sender stall
// becomes a permanent multi-second lag (sender emits oldest frames
// forever). NEVER pause proc.stdout here: fd3 audio shares the same
// process, so pausing video output also stalls audio (patah-patah).
if (vPipe.readableLength >= 30) {
vPipe.read(); // drop the oldest queued frame
}
vPipe.write({
data: au, data: au,
// One frame at videoFps: duration=1 in a 1/fps timebase → // One frame at videoFps: duration=1 in a 1/fps timebase →
// BaseMediaStream computes frametime=1000/fps ms → the RTP timestamp // BaseMediaStream computes frametime=1000/fps ms → the RTP timestamp
@@ -427,9 +436,6 @@ export async function demux(
streamIndex: 0, streamIndex: 0,
free: () => {}, free: () => {},
}); });
// vPipe is full (sender can't keep up) → pause the demuxer's ffmpeg
// stdout so the backlog can't grow. Resumed on 'drain' above.
gateSource(ok);
frameCount++; frameCount++;
if (frameCount === 1 || frameCount % 30 === 0) { if (frameCount === 1 || frameCount % 30 === 0) {
console.log( console.log(