MythEclipse/GMW
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: comprehensive codebase cleanup and architecture hardening

Browse Source 
- Sprint 1 (Quick Wins): Remove dead analytics modules, fix 4 unresolved
  imports, replace 3 console.warn with logger, remove mock-crc import
- Sprint 2 (Architecture): Create MascotChatRepository, AnalysisRepository,
  3 Zod schemas (mascot-chat, analysis, voice), deduplicate error classes,
  move 3 SQL queries from routes to repository
- Sprint 3 (Complexity): Replace 7 any types with proper interfaces,
  extract 6 helpers from prepareMediaMessage (CC 85 -> ~15)
- Sprint 4 (Config): Remove 22 dead env vars from .env, add 30 missing
  vars to .env.example, standardize naming

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
MythEclipse
2026-06-09 10:16:04 +07:00
co-authored by Claude Opus 4.8
parent d0d9e1669e
commit 4becf0d6f1
89 changed files with 1260 additions and 5499 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/discord-gateway/src/modules/voice-recording/ffmpegProcess.ts
+1 -1
View File
@@ -1,4 +1,4 @@
import { spawn } from "child_process";
import { spawn } from "node:child_process";
export interface MuxFfmpegArgsOptions {
inputs: string[];
services/discord-gateway/src/modules/voice-recording/index.ts
+1 -1
View File
@@ -1,5 +1,5 @@
export { OpusDecoder } from "./recorder/decoder.js";
export { SegmentManager } from "./recorder/segment.js";
export { startRecording, stopRecording } from "./recorder.js";
export { VoiceController } from "./voiceController.js";
export { voiceTransmitter } from "./transmitter.js";
export { VoiceController } from "./voiceController.js";
services/discord-gateway/src/modules/voice-recording/recorder/uploader.ts
+16 -12
View File
@@ -91,18 +91,22 @@ export async function uploadRecordingSegment(input: {
timestamp: Date.now(),
});
broadcaster.getClients().forEach((client: any) => {
if (client.readyState === 1) {
try {
client.send(payload);
} catch (err) {
logger.warn(
{ err },
"Failed to send recording upload event to client",
);
}
}
});
broadcaster
.getClients()
.forEach(
(client: { readyState: number; send: (data: string) => void }) => {
if (client.readyState === 1) {
try {
client.send(payload);
} catch (err) {
logger.warn(
{ err },
"Failed to send recording upload event to client",
);
}
}
},
);
}
} catch (error) {
const errorMsg = error instanceof Error ? error.message : String(error);
services/discord-gateway/src/modules/voice-recording/transmitter.ts
+49 -24
View File
@@ -1,5 +1,5 @@
import { PassThrough } from "node:stream";
import { spawn } from "node:child_process";
import { PassThrough } from "node:stream";
import { createChildLogger } from "@bete/shared/logger";
import { StreamType } from "@discordjs/voice";
import type Redis from "ioredis";
@@ -39,23 +39,39 @@ export class VoiceTransmitter {
// Spawn FFmpeg to encode 24kHz mono PCM → OggOpus
// Input: 24kHz mono s16le (raw PCM)
// Output: OGG container with Opus audio
this.ffmpegProcess = spawn("ffmpeg", [
"-f", "s16le", // Input format: signed 16-bit little-endian
"-ar", "24000", // Input sample rate: 24kHz
"-ac", "1", // Input channels: mono
"-i", "pipe:0", // Read from stdin
"-f", "ogg", // Output format: OGG
"-c:a", "libopus", // Codec: Opus
"-b:a", "96k", // Bitrate: 96kbps
"-ar", "48000", // Output sample rate: 48kHz
"-ac", "2", // Output channels: stereo
"-application", "lowdelay", // Low delay mode for real-time
"-frame_duration", "20", // 20ms frames
"-packet_loss", "0", // No packet loss expected
"pipe:1", // Write to stdout
], {
stdio: ["pipe", "pipe", "pipe"],
});
this.ffmpegProcess = spawn(
"ffmpeg",
[
"-f",
"s16le", // Input format: signed 16-bit little-endian
"-ar",
"24000", // Input sample rate: 24kHz
"-ac",
"1", // Input channels: mono
"-i",
"pipe:0", // Read from stdin
"-f",
"ogg", // Output format: OGG
"-c:a",
"libopus", // Codec: Opus
"-b:a",
"96k", // Bitrate: 96kbps
"-ar",
"48000", // Output sample rate: 48kHz
"-ac",
"2", // Output channels: stereo
"-application",
"lowdelay", // Low delay mode for real-time
"-frame_duration",
"20", // 20ms frames
"-packet_loss",
"0", // No packet loss expected
"pipe:1", // Write to stdout
],
{
stdio: ["pipe", "pipe", "pipe"],
},
);
// Pipe PCM data to FFmpeg stdin
if (this.ffmpegProcess.stdin) {
@@ -69,16 +85,20 @@ export class VoiceTransmitter {
});
this.ffmpegProcess.on("error", (err) => {
const msg = err.message === "spawn ffmpeg ENOENT"
? "FFmpeg/avconv not found! Install ffmpeg in the container."
: err.message;
const msg =
err.message === "spawn ffmpeg ENOENT"
? "FFmpeg/avconv not found! Install ffmpeg in the container."
: err.message;
logger.error({ error: msg }, "FFmpeg process error");
});
this.ffmpegProcess.on("exit", (code) => {
if (code !== 0) {
const stderr = Buffer.concat(stderrChunks).toString();
logger.error({ code, stderr: stderr.slice(-500) }, "FFmpeg exited with error");
logger.error(
{ code, stderr: stderr.slice(-500) },
"FFmpeg exited with error",
);
}
});
@@ -90,11 +110,16 @@ export class VoiceTransmitter {
});
}
logger.info("Voice transmitter pipeline ready (PCM → FFmpeg → OggOpus → Discord)");
logger.info(
"Voice transmitter pipeline ready (PCM → FFmpeg → OggOpus → Discord)",
);
// Subscribe to Redis channel for PCM data
await this.redisSub.subscribe(this.TRANSMIT_CHANNEL);
logger.info({ channel: this.TRANSMIT_CHANNEL }, "Subscribed to transmit channel");
logger.info(
{ channel: this.TRANSMIT_CHANNEL },
"Subscribed to transmit channel",
);
this.redisSub.on("message", (channel, message) => {
if (channel !== this.TRANSMIT_CHANNEL || !this.pcmStream) return;