fix(ai-moderation): restrict vision cache pre-download check to stickers and custom emojis only

services/discord-gateway/src/modules/ai-moderation/llmModerationClient.ts

@@ -1282,22 +1282,6 @@ async function _runSingleMediaAnalysis(
           return;
         }
 
-        // Check vision cache BEFORE downloading
-        const attVisionKey = makeImageCacheKey(urlToUse);
-        const cachedVision = await getCachedMediaAnalysis(attVisionKey);
-        if (cachedVision) {
-          log.debug(
-            { attachmentId: att.id, cacheKey: attVisionKey },
-            "Vision cache HIT for attachment — skipped download",
-          );
-          const sourceLabel = `[gambar di atas adalah attachment ${att.filename} dari pesan id=${att.message_id}]`;
-          const analysisText = `[Media analysis for message ${att.message_id}] ${sourceLabel}: ${cachedVision}`;
-          const existing = mediaAnalysisMap.get(targetId) ?? [];
-          existing.push(analysisText);
-          mediaAnalysisMap.set(targetId, existing);
-          return;
-        }
-
         const controller = new AbortController();
         const timeoutId = setTimeout(() => controller.abort(), 15000);
 
@@ -1463,12 +1447,13 @@ async function _runSingleMediaAnalysis(
         // Skip if we already have 8 images
         if ((imageMap.get(targetId)?.length ?? 0) >= 8) return;
 
-        // Vision cache check before download
+        // Vision cache check before download (sticker & emoji keys only, since
+        // their cache keys are consistent between check and store — embed URLs
+        // use base64 data URL keys that never match the CDN URL).
+        if (candidate.customEmojiId || candidate.stickerName) {
           const visionCacheKey = candidate.customEmojiId
             ? makeCustomEmojiCacheKey(candidate.customEmojiId)
-          : candidate.stickerName
+            : makeStickerCacheKey(candidate.stickerName!);
-            ? makeStickerCacheKey(candidate.stickerName)
-            : makeImageCacheKey(candidate.url);
           const cachedVision = await getCachedMediaAnalysis(visionCacheKey);
           if (cachedVision) {
             log.debug(
@@ -1481,6 +1466,7 @@ async function _runSingleMediaAnalysis(
             mediaAnalysisMap.set(targetId, existing);
             return;
           }
+        }
 
         // Sticker download cache
         if (candidate.stickerName && isStickerCacheReady()) {