MythEclipse/GMW
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(voice): restore voice features and apply critical optimizations

Browse Source 
Voice Feature Restoration:
- Implemented full Redis pub/sub pipeline for real-time voice data
- Added VOICE_PCM and VOICE_ACTIVE_USER Redis channels
- Implemented EventBroadcaster.voicePcmData() and voiceActiveUser() methods
- Extended backend redis-bridge to subscribe to voice channels
- Updated backend WebSocket server for binary PCM broadcast
- Replaced globalThis PcmBroadcaster pattern with proper EventBroadcaster DI
- Fixed root cause: PcmBroadcaster functions were never initialized

Bug Fixes:
- Fixed prism-media version conflict (2.0.0-alpha.0 → 1.3.5)
- Fixed type inconsistency in commandHandler.ts (AudioPlayerStatus → string)

Critical Optimizations:
- P1.1: Fixed unbounded memory growth in aiAnalyzer (added LRU caching, max 10K entries)
- P1.2: Converted sync file I/O to async in audio hot paths (recorder, sessionRecording)
- P1.3: Replaced process.exit(1) with proper error handling (bootstrap, aiAnalysisWorker)

Code Quality:
- Removed unused logger field in EventBroadcaster
- Replaced console.* with structured logger.* calls (player, decoder)
- Fixed typos and removed commented debug code
- Added DatabaseError class for better error handling

Files Modified: 18 (discord-gateway: 14, backend: 3, root: 1)
Architecture: Discord → EventBroadcaster → Redis → Backend WebSocket → Frontend

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
MythEclipse
2026-06-08 19:14:34 +07:00
co-authored by Claude Opus 4.8
parent 2643a3c278
commit 13a75a5101
18 changed files with 243 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/discord-gateway/src/modules/voice-recording/packetFilter.ts
-4
View File
@@ -26,16 +26,12 @@ export class PacketFilter extends Transform {
this.push(chunk);
} else {
this.filteredCount++;
if (this.filteredCount % 10 === 0) {
// console.log(`[packet-filter] Filtered ${this.filteredCount} small packets (size < ${this.minPacketSize} bytes)`);
}
}
callback();
}
_flush(callback: TransformCallback): void {
// console.log(`[packet-filter] Total packets: ${this.totalCount}, filtered: ${this.filteredCount}, passed: ${this.totalCount - this.filteredCount}`);
callback();
}
}
services/discord-gateway/src/modules/voice-recording/player.ts
+5 -2
View File
@@ -1,4 +1,5 @@
import { Readable } from "node:stream";
import { createChildLogger } from "@bete/shared/logger";
import {
AudioPlayer,
AudioPlayerStatus,
@@ -10,6 +11,8 @@ import {
} from "@discordjs/voice";
import type { DiscordPlayerOwner, DiscordPlayOptions } from "./mediaTypes.js";
const logger = createChildLogger("player");
export class DiscordPlayer {
private player: AudioPlayer;
private connection: VoiceConnection | null = null;
@@ -21,11 +24,11 @@ export class DiscordPlayer {
this.player = createAudioPlayer();
this.player.on(AudioPlayerStatus.Playing, () => {
console.log("[player] Audio player is now playing!");
logger.info("Audio player is now playing!");
});
this.player.on("error", (error) => {
console.error(`[player] Error: ${error.message}`);
logger.error({ error: error.message }, "Audio player error");
this.owner = "none";
this.resource = null;
});
services/discord-gateway/src/modules/voice-recording/recorder.ts
+43 -24
View File
@@ -1,4 +1,4 @@
import fs from "node:fs";
import fs, { promises as fsPromises } from "node:fs";
import path from "node:path";
import { createChildLogger } from "@bete/shared/logger";
import { retryWithBackoff } from "@bete/shared/utils";
@@ -13,7 +13,7 @@ import {
} from "@discordjs/voice";
import type { Client, VoiceChannel } from "discord.js-selfbot-v13";
import { config } from "../../shared/config/config.js";
import type { PcmBroadcaster } from "../message-capture/types.js";
import type { EventBroadcaster } from "../event-broadcaster/eventBroadcaster.js";
import { PacketFilter } from "./packetFilter.js";
import { OpusDecoder } from "./recorder/decoder.js";
import {
@@ -30,12 +30,25 @@ import { uploadRecordingSegment } from "./recorder/uploader.js";
const logger = createChildLogger("recorder");
let _eventBroadcaster: EventBroadcaster | undefined;
export function setEventBroadcaster(broadcaster: EventBroadcaster | undefined) {
_eventBroadcaster = broadcaster;
}
const recordingsDir = config.RECORDINGS_DIR;
// Pastikan folder recordings ada
if (!fs.existsSync(recordingsDir)) {
fs.mkdirSync(recordingsDir, { recursive: true });
}
(async () => {
try {
await fsPromises.mkdir(recordingsDir, { recursive: true });
} catch (error) {
// Directory might already exist, that's fine
if ((error as NodeJS.ErrnoException).code !== "EEXIST") {
logger.error({ error }, "Failed to create recordings directory");
}
}
})();
const activeSessions = new Map<string, RecordingSession>();
@@ -115,7 +128,6 @@ export async function startRecording(
}
const receiver = connection.receiver;
const broadcaster = globalThis as typeof globalThis & PcmBroadcaster;
// Dengarkan siapapun yang mulai bicara
receiver.speaking.on("start", async (userId) => {
@@ -130,7 +142,7 @@ export async function startRecording(
);
// Notify webserver
broadcaster.updateActiveUser?.(userId, {
_eventBroadcaster?.voiceActiveUser(userId, {
username: userMetadata.username,
avatar: userMetadata.avatarUrl,
speaking: true,
@@ -140,9 +152,9 @@ export async function startRecording(
if (receiver.subscriptions.has(userId)) return;
const userDir = path.join(recordingsDir, userId);
if (!fs.existsSync(userDir)) {
fs.mkdirSync(userDir, { recursive: true });
}
await fsPromises.mkdir(userDir, { recursive: true }).catch(() => {
// Directory already exists, ignore
});
try {
// --- OGG file recording with segment rotation ---
@@ -166,13 +178,12 @@ export async function startRecording(
cooldownMs: config.DECODER_COOLDOWN_MS,
rotateMs: config.DECODER_ROTATE_MS,
onData: (pcm) => {
if (!broadcaster.broadcastPcmToWeb) return;
// Downsample 48kHz stereo → 24kHz mono (left channel, every 2nd sample)
const outBuf = Buffer.alloc(pcm.length / 4);
for (let i = 0; i < outBuf.length / 2; i++) {
outBuf.writeInt16LE(pcm.readInt16LE(i * 8), i * 2);
}
broadcaster.broadcastPcmToWeb(outBuf, userId);
_eventBroadcaster?.voicePcmData(outBuf, userId);
},
});
@@ -200,16 +211,25 @@ export async function startRecording(
activeSession?.startTime ?? 0,
config.RECORDING_SEGMENT_MS,
);
fs.writeFileSync(
currentSegment.jsonFilename,
JSON.stringify(metadata, null, 2),
);
if (config.VERBOSE) {
logger.info(
{ jsonFile: currentSegment.jsonFilename },
"Metadata saved",
);
}
fsPromises
.writeFile(
currentSegment.jsonFilename,
JSON.stringify(metadata, null, 2),
)
.then(() => {
if (config.VERBOSE) {
logger.info(
{ jsonFile: currentSegment.jsonFilename },
"Metadata saved",
);
}
})
.catch((err: unknown) => {
logger.error(
{ error: err instanceof Error ? err.message : String(err) },
"Failed to write segment metadata",
);
});
// Trigger async voice segment upload
const segmentId = `${userId}-${currentSegment.startTime}`;
@@ -240,7 +260,6 @@ export async function startRecording(
audioStream.on("data", (chunk: Buffer) => {
if (chunk.length < 8) return;
segmentManager.rotateIfNeeded(oggPacketStream);
if (!broadcaster.broadcastPcmToWeb) return;
decoder.rotateIfNeeded();
decoder.write(chunk);
});
@@ -248,7 +267,7 @@ export async function startRecording(
audioStream.on("end", () => {
segmentManager.close(oggPacketStream);
decoder.destroy();
broadcaster.updateActiveUser?.(userId, {
_eventBroadcaster?.voiceActiveUser(userId, {
username: userMetadata.username,
avatar: userMetadata.avatarUrl,
speaking: false,
services/discord-gateway/src/modules/voice-recording/recorder/decoder.ts
+5 -6
View File
@@ -1,8 +1,10 @@
import { createRequire } from "node:module";
import { createChildLogger } from "@bete/shared/logger";
import * as prism from "prism-media";
import { config } from "../../../shared/config/config.js";
const require = createRequire(import.meta.url);
const logger = createChildLogger("opus-decoder");
interface OpusDecoderRuntime {
isBun: boolean;
@@ -84,10 +86,7 @@ export class OpusDecoder {
try {
decoder.write(chunk);
} catch (error) {
console.warn(
"[recorder] Opus decoder write failed, cooling down:",
error,
);
logger.warn({ error }, "Opus decoder write failed, cooling down");
this.coolDown();
}
}
@@ -107,14 +106,14 @@ export class OpusDecoder {
const decoder = this.createDecoderFn();
decoder.on("data", this.onData);
decoder.on("error", (error) => {
console.warn("[recorder] Opus decoder error, cooling down:", error);
logger.warn({ error }, "Opus decoder error, cooling down");
this.coolDown();
});
this.decoder = decoder;
this.createdAt = Date.now();
return decoder;
} catch (error) {
console.warn("[recorder] Opus decoder init failed, cooling down:", error);
logger.warn({ error }, "Opus decoder init failed, cooling down");
this.disabledUntil = Date.now() + this.cooldownMs;
return null;
}
services/discord-gateway/src/modules/voice-recording/recorder/sessionRecording.ts
+12 -9
View File
@@ -1,4 +1,4 @@
import fs from "node:fs";
import fs, { promises as fsPromises } from "node:fs";
import path from "node:path";
import type { UserMetadata } from "../../message-capture/types.js";
import {
@@ -71,8 +71,11 @@ export interface RecordingSession {
export interface FinalizeRecordingSessionDependencies {
endTime?: number;
mkdir?: (dir: string) => void;
writeJson?: (file: string, metadata: SessionRecordingMetadata) => void;
mkdir?: (dir: string) => Promise<void>;
writeJson?: (
file: string,
metadata: SessionRecordingMetadata,
) => Promise<void>;
runFfmpeg?: (args: string[]) => Promise<void>;
}
@@ -153,18 +156,18 @@ export async function finalizeRecordingSession(
const outputFile = path.join(sessionDir, "full.ogg");
const metadataFile = path.join(sessionDir, "session.json");
const mkdir =
dependencies.mkdir ?? ((dir) => fs.mkdirSync(dir, { recursive: true }));
dependencies.mkdir ?? ((dir) => fsPromises.mkdir(dir, { recursive: true }));
const writeJson =
dependencies.writeJson ??
((file, metadata) =>
fs.writeFileSync(file, JSON.stringify(metadata, null, 2)));
fsPromises.writeFile(file, JSON.stringify(metadata, null, 2)));
const runFfmpeg = dependencies.runFfmpeg ?? defaultRunFfmpeg;
mkdir(sessionDir);
await mkdir(sessionDir);
const metadata = session.snapshot(endTime);
if (metadata.segments.length === 0) {
writeJson(metadataFile, { ...metadata, status: "empty" });
await writeJson(metadataFile, { ...metadata, status: "empty" });
return;
}
@@ -177,13 +180,13 @@ export async function finalizeRecordingSession(
codec: "libopus",
}),
);
writeJson(metadataFile, {
await writeJson(metadataFile, {
...metadata,
status: "completed",
outputFile,
});
} catch (error) {
writeJson(metadataFile, {
await writeJson(metadataFile, {
...metadata,
status: "failed",
error: error instanceof Error ? error.message : String(error),